Chromium Code Reviews
Help | Chromium Project | Sign in
(196)

Issue 1036001: Add a DOMUI datasource that will handle the net-internals page.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by eroman
Modified:
2 years, 10 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Add a DOMUI datasource that will handle the net-internals page.

Right now it is bound to the temporary URL "chrome://net2", since the frontend is under construction.
(Loading this page right now just shows a dummy HTML page.)

This change is a first step to transitioning the about:net-internals / about:network pages from C++ to javascript.
Note that the network stuff needs to run on the IO thread, however the DOMUI infrastructure is all set up to run on the UI thread.
I work around this by proxying things back and forth through the IO thread. Hopefully in subsequent iterations this overhead can be removed, by exposing a sort of "IO thread DOMUI".

BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41791

Patch Set 1 #

Patch Set 2 : Fix some style issues #

Total comments: 7

Patch Set 3 : address mbelshe comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+406 lines, -0 lines) Lint Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M chrome/browser/dom_ui/dom_ui_factory.cc View 1 2 chunks +3 lines, -0 lines 0 comments 0 errors Download
A chrome/browser/dom_ui/net_internals_ui.h View 1 1 chunk +18 lines, -0 lines 0 comments 1 errors Download
A chrome/browser/dom_ui/net_internals_ui.cc View 1 2 1 chunk +347 lines, -0 lines 0 comments 3 errors Download
A chrome/browser/resources/net_internals/index.html View 1 chunk +32 lines, -0 lines 0 comments 0 errors Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
M chrome/common/url_constants.h View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M chrome/common/url_constants.cc View 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 4
eroman
4 years, 1 month ago #1
Mike Belshe
lgtm http://codereview.chromium.org/1036001/diff/8001/9004 File chrome/browser/dom_ui/net_internals_ui.cc (right): http://codereview.chromium.org/1036001/diff/8001/9004#newcode56 chrome/browser/dom_ui/net_internals_ui.cc:56: // it the argument |value|. nit: This function ...
4 years, 1 month ago #2
eroman
http://codereview.chromium.org/1036001/diff/8001/9004 File chrome/browser/dom_ui/net_internals_ui.cc (right): http://codereview.chromium.org/1036001/diff/8001/9004#newcode56 chrome/browser/dom_ui/net_internals_ui.cc:56: // it the argument |value|. On 2010/03/16 22:14:50, Mike ...
4 years, 1 month ago #3
Mike Belshe
4 years, 1 month ago #4
http://codereview.chromium.org/1036001/diff/8001/9004
File chrome/browser/dom_ui/net_internals_ui.cc (right):

http://codereview.chromium.org/1036001/diff/8001/9004#newcode56
chrome/browser/dom_ui/net_internals_ui.cc:56: // it the argument |value|.
You're right - I was looking at the wrong instance of CallJavascriptFunction.

On 2010/03/16 23:15:58, eroman wrote:
> On 2010/03/16 22:14:50, Mike Belshe wrote:
> > nit:  This function will also delete |value|.
> 
> Where do you see that? |value| should not be deleted by this function...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6