Split spoken feedback up on a per format rule basis.

chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
index 443885c3735b110630a06d6d976960221ab7ff55..bf6871092c27dfe7a1f858d7e63d22ec09d4722a 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
@@ -23,17 +23,67 @@ OutputE2ETest.prototype = {
   }
 };
 
-TEST_F('OutputE2ETest', 'RenderBasic', function() {
+TEST_F('OutputE2ETest', 'Links', function() {
   this.runWithLoadedTree('<a href="#">Click here</a>',
     function(root) {
-      var link = root.firstChild.firstChild;
-      var range = cursors.Range.fromNode(link);
+      var el = root.firstChild.firstChild;
+      var range = cursors.Range.fromNode(el);
       var o = new Output().withSpeechAndBraille(range, null, 'navigate');
-      assertEqualsJSON({string_: 'Click here Link', 'spans_': [
-                        {value: 'name', start: 0, end: 10},
-                        // Link earcon.
-                        {value: {}, start: 11, end: 15}
-          ]},
-          o.getBuffer());
+      assertEqualsJSON({string_: 'Click hereLink', 'spans_': [
+        // Attributes.
+        {value: 'name', start: 0, end: 10},
+        {value: 'role', start: 10, end: 14},
+
+        // Link earcon (based on the role).
+        {value: {}, start: 10, end: 14}
+      ]},
+                       o.toSpannable());
+  });
+});
+
+TEST_F('OutputE2ETest', 'Checkbox', function() {
+  this.runWithLoadedTree('<input type="checkbox">',
+    function(root) {
+      var el = root.firstChild.firstChild;
+      var range = cursors.Range.fromNode(el);
+      var o = new Output().withSpeechAndBraille(range, null, 'navigate');
+      assertEqualsJSON({string_: 'Check boxnot checked', 'spans_': [
+        // Attributes.
+        {value: 'name', start: 0, end: 0},
+        {value: 'role', start: 0, end: 9},
+        {value: 'state', start: 9, end: 20},
+
+        // Link earcon (based on the state).
+        {value: {}, start: 9, end: 20}
+      ]},
+                       o.toSpannable());

[dmazzoni, 2015/04/13 22:56:52]

nit: indentation (3x in this file with the same line essentially)

[David Tseng, 2015/04/15 17:58:35]

Done.

+  });
+});
+
+TEST_F('OutputE2ETest', 'InLineTextBoxValueGetsIgnored', function() {
+  this.runWithLoadedTree('<p>OK',
+    function(root) {
+      var el = root.firstChild.firstChild.firstChild;
+      assertEquals('inlineTextBox', el.role);
+      var range = cursors.Range.fromNode(el);
+      var o = new Output().withSpeechAndBraille(range, null, 'navigate');
+      assertEqualsJSON({string_: 'OK', 'spans_': [
+        // Attributes.
+        {value: 'name', start: 0, end: 2}
+      ]},
+                       o.toSpannable());
+
+      el = root.firstChild.firstChild;
+      assertEquals('staticText', el.role);
+      range = cursors.Range.fromNode(el);
+      o = new Output().withSpeechAndBraille(range, null, 'navigate');
+      assertEqualsJSON({string_: 'OK', 'spans_': [
+        // Attributes.
+        {value: 'value', start: 0, end: 2},
+
+        // The name is an empty string.
+        {value: 'name', start: 2, end: 2}
+      ]},
+                       o.toSpannable());
   });
 });