Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

Issue 1035983003: Split spoken feedback up on a per format rule basis. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
diff --git a/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc b/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
index 7f8fe5ae5967edb9f9c9600126a394b56d9a289d..edc80b1ebda00fbbcd0abdde124c6aef69727861 100644
--- a/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
+++ b/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
@@ -263,15 +263,24 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, EnableSpokenFeedback) {
IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, FocusToolbar) {
EnableChromeVox();
chrome::ExecuteCommand(browser(), IDC_FOCUS_TOOLBAR);
- EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(),
- "about:blank*Tool bar Reload Button"));
+ EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "about:blank*"));
+ EXPECT_EQ("main", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Tool bar", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Reload", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Button", speech_monitor_.GetNextUtterance());
}
IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, TypeInOmnibox) {
EnableChromeVox();
chrome::ExecuteCommand(browser(), IDC_FOCUS_LOCATION);
- EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "*Edit text*"));
+ EXPECT_TRUE(
+ MatchPattern(speech_monitor_.GetNextUtterance(), "*about:blank*"));
+ EXPECT_EQ("main", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Tool bar", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Address and search bar", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("about:blank", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Edit text", speech_monitor_.GetNextUtterance());
SendKeyPress(ui::VKEY_X);
EXPECT_EQ("x", speech_monitor_.GetNextUtterance());
@@ -290,13 +299,17 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, FocusShelf) {
EnableChromeVox();
EXPECT_TRUE(PerformAcceleratorAction(ash::FOCUS_SHELF));
- const char* expected = app_list::switches::IsExperimentalAppListEnabled()
- ? "Shelf Tool bar Launcher Button"
- : "Shelf Tool bar Apps Button";
- EXPECT_EQ(expected, speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Shelf", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Tool bar", speech_monitor_.GetNextUtterance());
+ if (app_list::switches::IsExperimentalAppListEnabled())
+ EXPECT_EQ("Launcher", speech_monitor_.GetNextUtterance());
+ else
+ EXPECT_EQ("Apps", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Button", speech_monitor_.GetNextUtterance());
SendKeyPress(ui::VKEY_TAB);
- EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "* Button"));
+ EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "*"));
+ EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "Button"));
}
IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, NavigateAppLauncher) {
@@ -305,17 +318,19 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, NavigateAppLauncher) {
EXPECT_TRUE(PerformAcceleratorAction(ash::FOCUS_SHELF));
while (true) {
std::string utterance = speech_monitor_.GetNextUtterance();
- if (MatchPattern(utterance, "*Button"))
+ if (MatchPattern(utterance, "Button"))
break;
}
SendKeyPress(ui::VKEY_RETURN);
- EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(),
- "Search or type U R L Edit text"));
+ EXPECT_EQ("Search or type U R L", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Edit text", speech_monitor_.GetNextUtterance());
SendKeyPress(ui::VKEY_DOWN);
- EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "* Button"));
+ EXPECT_EQ("Dialog", speech_monitor_.GetNextUtterance());
+ EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "*"));
+ EXPECT_EQ("Button", speech_monitor_.GetNextUtterance());
}
IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, OpenStatusTray) {
@@ -326,7 +341,8 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, OpenStatusTray) {
EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "time *"));
EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(),
"Battery is*full."));
- EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "*Button"));
+ EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "*"));
+ EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "Button"));
}
IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, NavigateSystemTray) {
@@ -335,15 +351,16 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, NavigateSystemTray) {
EXPECT_TRUE(PerformAcceleratorAction(ash::SHOW_SYSTEM_TRAY_BUBBLE));
while (true) {
std::string utterance = speech_monitor_.GetNextUtterance();
- if (MatchPattern(utterance, "* Button"))
+ if (MatchPattern(utterance, "Button"))
break;
}
// Navigate to Bluetooth sub-menu and open it.
while (true) {
SendKeyPress(ui::VKEY_TAB);
- std::string utterance = speech_monitor_.GetNextUtterance();
- if (MatchPattern(utterance, "*Bluetooth* Button"))
+ std::string content = speech_monitor_.GetNextUtterance();
+ std::string role = speech_monitor_.GetNextUtterance();
+ if (MatchPattern(content, "*Bluetooth*") && MatchPattern(role, "Button"))
break;
}
SendKeyPress(ui::VKEY_RETURN);
@@ -352,12 +369,16 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, NavigateSystemTray) {
while (true) {
SendKeyPress(ui::VKEY_TAB);
std::string utterance = speech_monitor_.GetNextUtterance();
- if (MatchPattern(utterance, "Previous menu Button"))
+ if (MatchPattern(utterance, "Previous menu"))
break;
}
SendKeyPress(ui::VKEY_RETURN);
- EXPECT_TRUE(
- MatchPattern(speech_monitor_.GetNextUtterance(), "*Bluetooth* Button"));
+
+ while (true) {
+ std::string utterance = speech_monitor_.GetNextUtterance();
+ if (MatchPattern(speech_monitor_.GetNextUtterance(), "Button"))
+ break;
+ }
}
// See http://crbug.com/443608
@@ -387,11 +408,12 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, OverviewMode) {
EXPECT_TRUE(PerformAcceleratorAction(ash::TOGGLE_OVERVIEW));
EXPECT_EQ("Edit text", speech_monitor_.GetNextUtterance());
- EXPECT_EQ("Alert Entered window overview mode",
- speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Alert", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Entered window overview mode", speech_monitor_.GetNextUtterance());
SendKeyPress(ui::VKEY_TAB);
- EXPECT_EQ("about:blank Button", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("about:blank", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Button", speech_monitor_.GetNextUtterance());
}
#if defined(MEMORY_SANITIZER)
@@ -559,8 +581,11 @@ IN_PROC_BROWSER_TEST_F(GuestSpokenFeedbackTest, FocusToolbar) {
chrome::ExecuteCommand(browser(), IDC_FOCUS_TOOLBAR);
- EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(),
- "about:blank*Tool bar Reload Button"));
+ EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "about:blank*"));
+ EXPECT_EQ("main", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Tool bar", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Reload", speech_monitor_.GetNextUtterance());
+ EXPECT_EQ("Button", speech_monitor_.GetNextUtterance());
}
//

Powered by Google App Engine
This is Rietveld 408576698