PlzNavigate: Send EnableViewSourceMode at commit time when reusing a RFH

PlzNavigate: Send EnableViewSourceMode at commit time when reusing a RFH

This CL ensures that we properly send an EnableViewSourceMode IPC to the
RnederView of a reused RenderFrameHost at commit time when the request is for a
view source mode navigation. This is needed because on error a RenderView could
exit the view source mode. This fixes the
RenderFrameHostManagerTest.AlwaysSendEnableViewSourceMode test with PlzNavigate
enabled.

BUG=439423
Committed: https://crrev.com/cf932f0050766d998952f1e4f5c6f33567a61c2e
Cr-Commit-Position: refs/heads/master@{#322561}

[clamy, 2015-03-26 16:13:48]

clamy@chromium.org changed reviewers:
+ carlosk@chromium.org, fdegans@chromium.org, nasko@chromium.org

[clamy, 2015-03-26 16:13:48]

@carlosk, nasko: PTAL
@fdegans: FYI

[clamy, 2015-03-26 16:15:13]

https://codereview.chromium.org/1035983002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/navigator_impl.cc (right):

https://codereview.chromium.org/1035983002/diff/20001/content/browser/frame_h...
content/browser/frame_host/navigator_impl.cc:702: // happen. When reusing the
same renderer, overwrite to recover the mode.
Note that this cannot happen in GetFrameHostForNavigation since we would end up
sending the message twice (once when it's called from BeginNavigation and once
when it's called from CommitNavigation).

[nasko, 2015-03-26 20:46:31]

LGTM with a nit.

https://codereview.chromium.org/1035983002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/navigator_impl.cc (right):

https://codereview.chromium.org/1035983002/diff/20001/content/browser/frame_h...
content/browser/frame_host/navigator_impl.cc:702: // happen. When reusing the
same renderer, overwrite to recover the mode.
On 2015/03/26 16:15:13, clamy wrote:
> Note that this cannot happen in GetFrameHostForNavigation since we would end
up
> sending the message twice (once when it's called from BeginNavigation and once
> when it's called from CommitNavigation).

Acknowledged.

https://codereview.chromium.org/1035983002/diff/20001/content/browser/frame_h...
content/browser/frame_host/navigator_impl.cc:706:
render_frame_host->render_view_host()->Send(
We should (D)CHECK here that the RFH is the top-level one. I wouldn't expect a
subframe to be navigating to view-source.

[carlosk, 2015-03-27 10:13:45]

LGTM

[clamy, 2015-03-27 10:53:12]

Thanks!

https://codereview.chromium.org/1035983002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/navigator_impl.cc (right):

https://codereview.chromium.org/1035983002/diff/20001/content/browser/frame_h...
content/browser/frame_host/navigator_impl.cc:706:
render_frame_host->render_view_host()->Send(
On 2015/03/26 20:46:31, nasko wrote:
> We should (D)CHECK here that the RFH is the top-level one. I wouldn't expect a
> subframe to be navigating to view-source.

Done.

[clamy, 2015-03-27 10:53:16]

The CQ bit was checked by clamy@chromium.org

[clamy, 2015-03-27 10:53:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
carlosk@chromium.org, nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/1035983002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-03-27 10:53:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035983002/40001

[commit-bot: I haz the power, 2015-03-27 12:21:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-27 12:22:37]

Patchset 3 (id:??) landed as
https://crrev.com/cf932f0050766d998952f1e4f5c6f33567a61c2e
Cr-Commit-Position: refs/heads/master@{#322561}