Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1035963003: Remove WebContentsImplTest::CrossSiteNavigationCanceled (Closed)

Created:
5 years, 9 months ago by clamy
Modified:
5 years, 9 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed WebContentsImplTest::CrossSiteNavigationCanceled This test checks that if a new navigation does not commit after the current renderer has run its unload handler this does not leave the WebContents in a stuck state. However, following https://codereview.chromium.org/464593003/, the current renderer will only run its unload handler after teh new navigation has committed. Therefore, this test is no longer applicable. BUG=402020 Committed: https://crrev.com/8dce417852ca909fedb7a36e35c1173b9c157dab Cr-Commit-Position: refs/heads/master@{#322552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
clamy
@creis: PTAL
5 years, 9 months ago (2015-03-26 15:35:20 UTC) #2
Charlie Reis
Yep, looks stale, so thanks for the cleanup. LGTM.
5 years, 9 months ago (2015-03-26 16:53:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035963003/1
5 years, 9 months ago (2015-03-27 10:23:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 11:10:32 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 11:11:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8dce417852ca909fedb7a36e35c1173b9c157dab
Cr-Commit-Position: refs/heads/master@{#322552}

Powered by Google App Engine
This is Rietveld 408576698