Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: tests/GeometryTest.cpp

Issue 1035943002: use new faster/vector impl for chopping conics (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fix bench Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkGeometry.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/GeometryTest.cpp
diff --git a/tests/GeometryTest.cpp b/tests/GeometryTest.cpp
index 846afaed2d06582479f0638d823a8e3a27e6f72b..0ec7d68abfbb0ff1505e6f1a2e426a2091dac16b 100644
--- a/tests/GeometryTest.cpp
+++ b/tests/GeometryTest.cpp
@@ -83,21 +83,6 @@ static void test_conic_eval_tan(skiatest::Reporter* reporter, const SkConic& con
check_pairs(reporter, 0, t, "conic-tan", v0.fX, v0.fY, v1.fX, v1.fY);
}
-static void test_conic_chop_half(skiatest::Reporter* reporter, const SkConic& conic) {
- SkConic dst0[2], dst1[2];
- conic.chop(dst0);
- conic.chop2(dst1);
-
- for (int i = 0; i < 2; ++i) {
- REPORTER_ASSERT(reporter, dst0[i].fW == dst1[i].fW);
- for (int j = 0; j < 3; ++j) {
- check_pairs(reporter, j, 0.5f, "conic-chop",
- dst0[i].fPts[j].fX, dst0[i].fPts[j].fY,
- dst0[i].fPts[j].fX, dst1[i].fPts[j].fY);
- }
- }
-}
-
static void test_conic(skiatest::Reporter* reporter) {
SkRandom rand;
for (int i = 0; i < 1000; ++i) {
@@ -108,7 +93,6 @@ static void test_conic(skiatest::Reporter* reporter) {
for (int k = 0; k < 10; ++k) {
SkScalar w = rand.nextUScalar1() * 2;
SkConic conic(pts, w);
- test_conic_chop_half(reporter, conic);
const SkScalar dt = SK_Scalar1 / 128;
SkScalar t = dt;
« no previous file with comments | « src/core/SkGeometry.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698