Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1035933002: Update mojo sdk to rev 912f52f69dadbe1e3cf9576f26731863770bcfc3 (Closed)

Created:
5 years, 9 months ago by sky
Modified:
5 years, 9 months ago
Reviewers:
jamesr, brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update mojo sdk to rev 912f52f69dadbe1e3cf9576f26731863770bcfc3 R=brettw@chromium.org, jamesr@chromium.org TBR=jamesr@chromium.org BUG=none TEST=none Committed: https://crrev.com/ce9161d6ac923454351a5e0d68dc1d25079c65a3 Cr-Commit-Position: refs/heads/master@{#322518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -43 lines) Patch
M build/module_args/mojo.gni View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/platform_channel_utils_posix.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/multiprocess_message_pipe_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/mojo.gni View 1 chunk +12 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/mojo_application.gni View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/BUILD.gn View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/mojo_services/src/content_handler/public/interfaces/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/mojo_services/src/http_server/public/interfaces/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/mojo_services/src/navigation/public/interfaces/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
This roll of mojo includes gn variable renames as requested by Brett. brettw: build/module_args/mojo.gni jamesr: ...
5 years, 9 months ago (2015-03-26 15:06:08 UTC) #1
brettw
.gni lgtm
5 years, 9 months ago (2015-03-26 23:33:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035933002/1
5 years, 9 months ago (2015-03-27 01:12:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 01:51:00 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 01:51:59 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ce9161d6ac923454351a5e0d68dc1d25079c65a3
Cr-Commit-Position: refs/heads/master@{#322518}

Powered by Google App Engine
This is Rietveld 408576698