Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 103593006: Allow GN imports to be processed from imports. (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
piman
CC:
chromium-reviews
Visibility:
Public.

Description

Allow GN imports to be processed from imports. This restriction is unnecessarily restrictive and I will need to be able to do this in a future CL. Rather than prevent variable collisions, this instead checks for value collisions so as long as you end up with the same value, the error won't be thrown. This mainly comes up with multiple imports, so the values will be the same. R=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241071

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -11 lines) Patch
M tools/gn/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/functions.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M tools/gn/gn.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/scope.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A tools/gn/scope_unittest.cc View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
7 years ago (2013-12-16 21:42:28 UTC) #1
piman
lgtm
7 years ago (2013-12-16 22:20:32 UTC) #2
brettw
7 years ago (2013-12-16 23:59:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r241071 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698