Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1035923004: Check that containers are supported by Chrome in requestMediaKeySystemAccess(). (Closed)

Created:
5 years, 9 months ago by sandersd (OOO until July 31)
Modified:
5 years, 9 months ago
Reviewers:
jrummell, ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check that containers are supported by Chrome in requestMediaKeySystemAccess(). This can only fail if a CDM declares support for a container that Chrome does not, which would be a bug in CDM registration. BUG=374751 Committed: https://crrev.com/571587c351897e2d4053959b8e4b988d96fed9aa Cr-Commit-Position: refs/heads/master@{#322486}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M media/blink/webencryptedmediaclient_impl.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sandersd (OOO until July 31)
5 years, 9 months ago (2015-03-26 17:50:39 UTC) #2
ddorwin
Please update the commit message to use the full method name. Only a few people ...
5 years, 9 months ago (2015-03-26 17:55:10 UTC) #3
sandersd (OOO until July 31)
https://codereview.chromium.org/1035923004/diff/1/media/blink/webencryptedmediaclient_impl.cc File media/blink/webencryptedmediaclient_impl.cc (right): https://codereview.chromium.org/1035923004/diff/1/media/blink/webencryptedmediaclient_impl.cc#newcode150 media/blink/webencryptedmediaclient_impl.cc:150: if (!net::IsSupportedMediaMimeType(container_lower)) On 2015/03/26 17:55:10, ddorwin wrote: > This ...
5 years, 9 months ago (2015-03-26 18:11:05 UTC) #4
ddorwin
lgtm
5 years, 9 months ago (2015-03-26 20:55:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035923004/20001
5 years, 9 months ago (2015-03-26 22:04:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 22:52:59 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 22:53:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/571587c351897e2d4053959b8e4b988d96fed9aa
Cr-Commit-Position: refs/heads/master@{#322486}

Powered by Google App Engine
This is Rietveld 408576698