Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 1035893002: Disable WPO for mini_installer (Closed)

Created:
5 years, 9 months ago by Sébastien Marchand
Modified:
5 years, 9 months ago
Reviewers:
robertshield, scottmg
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable WPO for mini_installer We need to do this because when doing a PGO build the /GL flag gets automatically set everywhere, and we're hitting this warning: https://msdn.microsoft.com/en-us/library/b8s7ctwz%28v=vs.90%29.aspx because of the custom memset implementation (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/installer/mini_installer/mini_installer.cc&q=mini_ins&sq=package:chromium&l=862) TBR=robertshield@chromium.org BUG=309849 Committed: https://crrev.com/ad97de14a378bec31acbd94e623a70f4473556b8 Cr-Commit-Position: refs/heads/master@{#322377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/installer/mini_installer.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Sébastien Marchand
PTAL.
5 years, 9 months ago (2015-03-26 05:14:16 UTC) #2
scottmg
(We could probably get rid of that memset (I think both of the reasons in ...
5 years, 9 months ago (2015-03-26 05:33:35 UTC) #3
scottmg
Actually, come to think of it, I don't remember ever implementing IgnoreAllDefaultLibraries in msvs_emulation.py. So ...
5 years, 9 months ago (2015-03-26 05:36:14 UTC) #4
scottmg
On 2015/03/26 05:36:14, scottmg wrote: > Actually, come to think of it, I don't remember ...
5 years, 9 months ago (2015-03-26 05:37:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035893002/1
5 years, 9 months ago (2015-03-26 13:55:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/52063)
5 years, 9 months ago (2015-03-26 14:03:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035893002/1
5 years, 9 months ago (2015-03-26 14:17:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 14:28:34 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 14:29:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad97de14a378bec31acbd94e623a70f4473556b8
Cr-Commit-Position: refs/heads/master@{#322377}

Powered by Google App Engine
This is Rietveld 408576698