Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1035873002: [DevTools] Support SVG file in DevTools window. [1/2 chromium] (Closed)

Created:
5 years, 9 months ago by horo
Modified:
5 years, 9 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, aandrey+blink_chromium.org, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Support SVG file in DevTools window. [1/2 chromium] We are using .svg file in ServiceWorkersView but the mime-type for .svg file is not correctly set. BUG=466871 Committed: https://crrev.com/3df099f5501d0def7f6164eefec1bcb09e71cc18 Cr-Commit-Position: refs/heads/master@{#322393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/webui/devtools_ui.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
horo
nkostylev@ Could you please review this?
5 years, 9 months ago (2015-03-26 02:21:29 UTC) #2
Nikita (slow)
lgtm
5 years, 9 months ago (2015-03-26 15:23:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035873002/1
5 years, 9 months ago (2015-03-26 15:23:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 16:08:21 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 16:08:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3df099f5501d0def7f6164eefec1bcb09e71cc18
Cr-Commit-Position: refs/heads/master@{#322393}

Powered by Google App Engine
This is Rietveld 408576698