Source/web/tests/ScrollingCoordinatorChromiumTest.cpp - Issue 103583007: Ensure that if FrameView::isScrollable() is false, the assoc WebLayer is, too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

Issue 103583007: Ensure that if FrameView::isScrollable() is false, the assoc WebLayer is, too. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: . Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

diff --git a/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp b/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

index 840d39b8a48af6d9fe4066344a053448c13c7c54..ad57ef9a6a15fff4354aa6cee323652a6198460b 100644

--- a/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

+++ b/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

@@ -143,9 +143,10 @@ TEST_F(ScrollingCoordinatorChromiumTest, fastScrollingByDefault)

ASSERT_TRUE(page->scrollingCoordinator());

ASSERT_TRUE(page->scrollingCoordinator()->coordinatesScrollingForFrameView(frameView));

- // Fast scrolling should be enabled by default.

+ // Fast scrolling should be enabled by default, BUT if the main frame is

+ // not scrollable, then the rootScrollLayer shouldn't be scrollable either.

jamesr 2014/01/06 23:46:01 can you add a case for what this was originally te

WebLayer* rootScrollLayer = getRootScrollLayer();

- ASSERT_TRUE(rootScrollLayer->scrollable());

+ ASSERT_FALSE(rootScrollLayer->scrollable());

ASSERT_FALSE(rootScrollLayer->shouldScrollOnMainThread());

ASSERT_FALSE(rootScrollLayer->haveWheelEventHandlers());

}

« no previous file with comments | « Source/core/page/scrolling/ScrollingCoordinator.cpp ('k') | no next file » | no next file with comments »