Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: content/browser/media/android/browser_media_player_manager.cc

Issue 103583005: Restart fullscreen video playback when switching back from background (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed one more buggy line and the fullscreen_player_is_released_ member which is not necessary now Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/browser_media_player_manager.cc
diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc
index 2273b5cdc23e4ad81c7bcd4393ebe896a3d8d5e0..cedc80d5fe2dc0bacde88e12b2d5b6417973057a 100644
--- a/content/browser/media/android/browser_media_player_manager.cc
+++ b/content/browser/media/android/browser_media_player_manager.cc
@@ -100,7 +100,6 @@ BrowserMediaPlayerManager::BrowserMediaPlayerManager(
: WebContentsObserver(WebContents::FromRenderViewHost(render_view_host)),
fullscreen_player_id_(-1),
pending_fullscreen_player_id_(-1),
- fullscreen_player_is_released_(false),
web_contents_(WebContents::FromRenderViewHost(render_view_host)),
weak_ptr_factory_(this) {
}
@@ -140,10 +139,6 @@ bool BrowserMediaPlayerManager::OnMessageReceived(const IPC::Message& msg) {
void BrowserMediaPlayerManager::FullscreenPlayerPlay() {
MediaPlayerAndroid* player = GetFullscreenPlayer();
if (player) {
- if (fullscreen_player_is_released_) {
- video_view_->OpenVideo();
- fullscreen_player_is_released_ = false;
- }
player->Start();
Send(new MediaPlayerMsg_DidMediaPlayerPlay(
routing_id(), fullscreen_player_id_));
@@ -162,8 +157,8 @@ void BrowserMediaPlayerManager::FullscreenPlayerPause() {
void BrowserMediaPlayerManager::FullscreenPlayerSeek(int msec) {
MediaPlayerAndroid* player = GetFullscreenPlayer();
if (player) {
- // TODO(kbalazs): if |fullscreen_player_is_released_| is true
- // at this point, player->GetCurrentTime() will be wrong until
+ // TODO(kbalazs): if the fullscreen player has been Release()-d and
+ // not restarted yet, player->GetCurrentTime() will be wrong until
// FullscreenPlayerPlay (http://crbug.com/322798).
OnSeekRequest(fullscreen_player_id_,
base::TimeDelta::FromMilliseconds(msec));
@@ -525,8 +520,6 @@ void BrowserMediaPlayerManager::OnReleaseResources(int player_id) {
MediaPlayerAndroid* player = GetPlayer(player_id);
if (player)
player->Release();
- if (player_id == fullscreen_player_id_)
- fullscreen_player_is_released_ = true;
#if defined(GOOGLE_TV)
WebContentsViewAndroid* view =

Powered by Google App Engine
This is Rietveld 408576698