Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: content/browser/media/android/browser_media_player_manager.cc

Issue 103583005: Restart fullscreen video playback when switching back from background (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed comment without whitespace noise Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/browser_media_player_manager.cc
diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc
index 43b93da7fc32d6c9e378c494eb07b1ae6bd99e2b..876ad562793ac4f58ea4b71f0ef644407a397c4b 100644
--- a/content/browser/media/android/browser_media_player_manager.cc
+++ b/content/browser/media/android/browser_media_player_manager.cc
@@ -59,6 +59,10 @@ BrowserMediaPlayerManager* BrowserMediaPlayerManager::Create(
return new BrowserMediaPlayerManager(rvh);
}
+ContentViewCoreImpl* BrowserMediaPlayerManager::GetContentViewCore() const {
+ return ContentViewCoreImpl::FromWebContents(web_contents());
+}
+
#if !defined(GOOGLE_TV)
// static
MediaPlayerAndroid* BrowserMediaPlayerManager::CreateMediaPlayer(
@@ -108,7 +112,6 @@ BrowserMediaPlayerManager::BrowserMediaPlayerManager(
: WebContentsObserver(WebContents::FromRenderViewHost(render_view_host)),
fullscreen_player_id_(-1),
pending_fullscreen_player_id_(-1),
- fullscreen_player_is_released_(false),
web_contents_(WebContents::FromRenderViewHost(render_view_host)),
weak_ptr_factory_(this) {
}
@@ -146,10 +149,6 @@ bool BrowserMediaPlayerManager::OnMessageReceived(const IPC::Message& msg) {
void BrowserMediaPlayerManager::FullscreenPlayerPlay() {
MediaPlayerAndroid* player = GetFullscreenPlayer();
if (player) {
- if (fullscreen_player_is_released_) {
- video_view_->OpenVideo();
- fullscreen_player_is_released_ = false;
- }
player->Start();
Send(new MediaPlayerMsg_DidMediaPlayerPlay(
routing_id(), fullscreen_player_id_));
@@ -190,6 +189,19 @@ void BrowserMediaPlayerManager::ExitFullscreen(bool release_media_player) {
player->SetVideoSurface(gfx::ScopedJavaSurface());
}
+void BrowserMediaPlayerManager::SuspendFullscreen() {
+ MediaPlayerAndroid* player = GetFullscreenPlayer();
+ if (player)
+ player->SetVideoSurface(gfx::ScopedJavaSurface());
+}
+
+void BrowserMediaPlayerManager::ResumeFullscreen(
+ gfx::ScopedJavaSurface surface) {
+ MediaPlayerAndroid* player = GetFullscreenPlayer();
+ if (player)
+ player->SetVideoSurface(surface.Pass());
+}
+
void BrowserMediaPlayerManager::OnTimeUpdate(int player_id,
base::TimeDelta current_time) {
Send(new MediaPlayerMsg_MediaTimeUpdate(
@@ -461,14 +473,11 @@ void BrowserMediaPlayerManager::OnEnterFullscreen(int player_id) {
if (video_view_.get()) {
fullscreen_player_id_ = player_id;
video_view_->OpenVideo();
- } else if (!ContentVideoView::HasContentVideoView()) {
+ } else if (!ContentVideoView::GetInstance()) {
// In Android WebView, two ContentViewCores could both try to enter
// fullscreen video, we just ignore the second one.
fullscreen_player_id_ = player_id;
- ContentViewCoreImpl* content_view_core_impl =
- ContentViewCoreImpl::FromWebContents(web_contents());
- video_view_.reset(new ContentVideoView(content_view_core_impl->GetContext(),
- content_view_core_impl->GetContentVideoViewClient(), this));
+ video_view_.reset(new ContentVideoView(this));
}
}
@@ -533,8 +542,6 @@ void BrowserMediaPlayerManager::OnReleaseResources(int player_id) {
MediaPlayerAndroid* player = GetPlayer(player_id);
if (player)
player->Release();
- if (player_id == fullscreen_player_id_)
- fullscreen_player_is_released_ = true;
#if defined(VIDEO_HOLE)
WebContentsViewAndroid* view =

Powered by Google App Engine
This is Rietveld 408576698