Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: content/browser/android/content_video_view.h

Issue 103583005: Restart fullscreen video playback when switching back from background (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed comment without whitespace noise Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_video_view.h
diff --git a/content/browser/android/content_video_view.h b/content/browser/android/content_video_view.h
index 2a86830def3b16ce053d09ae46b8506c7e188e13..6ffb786fae2e309557af871b19f2abfa603632c7 100644
--- a/content/browser/android/content_video_view.h
+++ b/content/browser/android/content_video_view.h
@@ -31,6 +31,8 @@ class ContentVideoView {
const base::android::ScopedJavaLocalRef<jobject>& client,
BrowserMediaPlayerManager* manager);
+ ContentVideoView(BrowserMediaPlayerManager* manager);
bulach 2014/01/06 15:44:03 nit: explicit
+
~ContentVideoView();
// To open another video on existing ContentVideoView.
@@ -39,8 +41,8 @@ class ContentVideoView {
static bool RegisterContentVideoView(JNIEnv* env);
static void KeepScreenOn(bool screen_on);
- // Return true if there is existing ContentVideoView object.
- static bool HasContentVideoView();
+ // Return the singleton object or NULL.
+ static ContentVideoView* GetInstance();
// Getter method called by the Java class to get the media information.
int GetVideoWidth(JNIEnv*, jobject obj) const;
@@ -55,6 +57,15 @@ class ContentVideoView {
// as we are quitting the app.
void ExitFullscreen(JNIEnv*, jobject, jboolean release_media_player);
+ // Supposed to be called when the application paused or stopped.
+ // Destroys the fullscreen view in a way that it can be recreated
+ // via ResumeFullscreenIfSuspended.
+ void SuspendFullscreen();
+
+ // Supposed to be called when the application switches back to foreground.
+ // Recreates the fullscreen view if it was suspended via SuspendFullscreen.
+ void ResumeFullscreenIfSuspended();
+
// Media control method called by the Java class.
void SeekTo(JNIEnv*, jobject obj, jint msec);
void Play(JNIEnv*, jobject obj);
@@ -80,6 +91,9 @@ class ContentVideoView {
// no further calls to the native object is allowed.
void DestroyContentVideoView(bool native_view_destroyed);
+ // Creates the corresponding ContentVideoView Java object.
+ JavaObjectWeakGlobalRef CreateJavaObject();
+
// Object that manages the fullscreen media player. It is responsible for
// handling all the playback controls.
BrowserMediaPlayerManager* manager_;
@@ -87,6 +101,12 @@ class ContentVideoView {
// Weak reference of corresponding Java object.
JavaObjectWeakGlobalRef j_content_video_view_;
+ enum FullscreenState {
+ ENTERED,
+ SUSPENDED,
+ RESUME
+ } fullscreen_state_;
+
DISALLOW_COPY_AND_ASSIGN(ContentVideoView);
};
« no previous file with comments | « no previous file | content/browser/android/content_video_view.cc » ('j') | content/browser/android/content_video_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698