Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java

Issue 103583005: Restart fullscreen video playback when switching back from background (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: handle everything at browser side Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java b/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
index 5e73d4f88c2a44a5dc89f02d9dcc90a873b51fe0..2589711109b84af02da916462d9b83bf9fecc513 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
@@ -335,11 +335,10 @@ public class ContentVideoView extends FrameLayout implements MediaController.Med
@Override
public void surfaceDestroyed(SurfaceHolder holder) {
- if (mNativeContentVideoView != 0) {
- nativeSetSurface(mNativeContentVideoView, null);
- }
+ // We expect the native side to call destroyContentVideoView
qinmin 2013/12/18 02:09:46 This is not right. When user hit the home button,
kbalazs 2013/12/18 19:45:05 If the user calls ContentView.onHide in it's activ
+ // before our surface could have been bone.
+ assert mVideoSurfaceView == null;
mSurfaceHolder = null;
- post(mExitFullscreenRunnable);
}
private void setMediaController(MediaController controller) {

Powered by Google App Engine
This is Rietveld 408576698