Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1035813002: Remove all usages of MojoGLES2GetGLES2Interface(). (Closed)

Created:
5 years, 9 months ago by alhaad
Modified:
5 years, 9 months ago
Reviewers:
piman
CC:
DaveMoore, chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all usages of MojoGLES2GetGLES2Interface(). All html_viewer entry points now have Mojo C thunks. R=piman@chromium.org BUG=453591 Committed: https://crrev.com/36152635213bc6633b030275f0cf34d2d04dff99 Cr-Commit-Position: refs/heads/master@{#322275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -38 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +6 lines, -14 lines 0 comments Download
M mojo/gpu/mojo_gles2_impl_autogen.cc View 4 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
alhaad
5 years, 9 months ago (2015-03-25 19:35:05 UTC) #2
piman
lgtm
5 years, 9 months ago (2015-03-25 19:36:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035813002/1
5 years, 9 months ago (2015-03-25 19:37:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-25 23:40:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035813002/1
5 years, 9 months ago (2015-03-25 23:52:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 00:36:23 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 00:37:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36152635213bc6633b030275f0cf34d2d04dff99
Cr-Commit-Position: refs/heads/master@{#322275}

Powered by Google App Engine
This is Rietveld 408576698