Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: net/base/net_error_list.h

Issue 1035803003: Fail DNS resolution if the result contains 127.0.53.53. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add 3 more test cases Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/dns/host_resolver_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file intentionally does not have header guards, it's included 5 // This file intentionally does not have header guards, it's included
6 // inside a macro to generate enum values. 6 // inside a macro to generate enum values.
7 7
8 // This file contains the list of network errors. 8 // This file contains the list of network errors.
9 9
10 // 10 //
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 NET_ERROR(SOCKET_SEND_BUFFER_SIZE_UNCHANGEABLE, -163) 333 NET_ERROR(SOCKET_SEND_BUFFER_SIZE_UNCHANGEABLE, -163)
334 334
335 // Failed to import a client certificate from the platform store into the SSL 335 // Failed to import a client certificate from the platform store into the SSL
336 // library. 336 // library.
337 NET_ERROR(SSL_CLIENT_AUTH_CERT_BAD_FORMAT, -164) 337 NET_ERROR(SSL_CLIENT_AUTH_CERT_BAD_FORMAT, -164)
338 338
339 // The SSL server requires falling back to a version older than the configured 339 // The SSL server requires falling back to a version older than the configured
340 // minimum fallback version, and thus fallback failed. 340 // minimum fallback version, and thus fallback failed.
341 NET_ERROR(SSL_FALLBACK_BEYOND_MINIMUM_VERSION, -165) 341 NET_ERROR(SSL_FALLBACK_BEYOND_MINIMUM_VERSION, -165)
342 342
343 // Resolving a hostname to an IP address list included the IPv4 address
344 // "127.0.53.53". This is a special IP address which ICANN has recommended to
345 // indicate there was a name collision, and alert admins to a potential
346 // problem.
347 NET_ERROR(ICANN_NAME_COLLISION, -166)
348
343 // Certificate error codes 349 // Certificate error codes
344 // 350 //
345 // The values of certificate error codes must be consecutive. 351 // The values of certificate error codes must be consecutive.
346 352
347 // The server responded with a certificate whose common name did not match 353 // The server responded with a certificate whose common name did not match
348 // the host name. This could mean: 354 // the host name. This could mean:
349 // 355 //
350 // 1. An attacker has redirected our traffic to his server and is 356 // 1. An attacker has redirected our traffic to his server and is
351 // presenting a certificate for which he knows the private key. 357 // presenting a certificate for which he knows the private key.
352 // 358 //
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
781 NET_ERROR(DNS_TIMED_OUT, -803) 787 NET_ERROR(DNS_TIMED_OUT, -803)
782 788
783 // The entry was not found in cache, for cache-only lookups. 789 // The entry was not found in cache, for cache-only lookups.
784 NET_ERROR(DNS_CACHE_MISS, -804) 790 NET_ERROR(DNS_CACHE_MISS, -804)
785 791
786 // Suffix search list rules prevent resolution of the given host name. 792 // Suffix search list rules prevent resolution of the given host name.
787 NET_ERROR(DNS_SEARCH_EMPTY, -805) 793 NET_ERROR(DNS_SEARCH_EMPTY, -805)
788 794
789 // Failed to sort addresses according to RFC3484. 795 // Failed to sort addresses according to RFC3484.
790 NET_ERROR(DNS_SORT_ERROR, -806) 796 NET_ERROR(DNS_SORT_ERROR, -806)
OLDNEW
« no previous file with comments | « no previous file | net/dns/host_resolver_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698