Source/core/html/imports/LinkImport.cpp - Issue 1035803002: Remove ResourceFetcher's access to a real FetchContext at frame detach time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/imports/LinkImport.cpp

Issue 1035803002: Remove ResourceFetcher's access to a real FetchContext at frame detach time (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/imports/LinkImport.cpp

diff --git a/Source/core/html/imports/LinkImport.cpp b/Source/core/html/imports/LinkImport.cpp

index f17da74aa75b9b8c8f267200647ed82f4f0886a7..a65747bf775adb88f903d552f9ea06b0b4ee6f84 100644

--- a/Source/core/html/imports/LinkImport.cpp

+++ b/Source/core/html/imports/LinkImport.cpp

@@ -128,9 +128,7 @@ HTMLLinkElement* LinkImport::link()

bool LinkImport::hasLoaded() const

{

- // Should never be called after importChildWasDestroyed was called.

- ASSERT(m_owner);

- return m_child && m_child->isDone() && !m_child->loader()->hasError();

+ return m_owner && m_child && m_child->isDone() && !m_child->loader()->hasError();

Mike West 2015/03/26 04:43:14 Why doesn't this ASSERT hold true anymore?

}

void LinkImport::ownerInserted()

« Source/core/dom/Document.cpp ('K') | « Source/core/fetch/ResourceFetcherTest.cpp ('k') | Source/core/loader/DocumentLoader.cpp » ('j') | no next file with comments »