Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1035793003: Exposes more mutation functions to MotionEventGeneric (Closed)

Created:
5 years, 9 months ago by sky
Modified:
5 years, 9 months ago
Reviewers:
tdresser
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exposes more mutation functions to MotionEventGeneric I want to keep around a MotionEventGeneric and mutate it over time. Since this class is an implementation detail (public API takes MotionEvent) it seems fine to allow consumers of it to mutate it directly. BUG=none TEST=covered by test R=tdresser@chromium.org Committed: https://crrev.com/f1eb0a7e1062b0ea684727df4d61c55a75fe4a87 Cr-Commit-Position: refs/heads/master@{#322218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -9 lines) Patch
M ui/events/gesture_detection/motion_event_generic.h View 2 chunks +10 lines, -6 lines 0 comments Download
M ui/events/gesture_detection/motion_event_generic.cc View 1 chunk +7 lines, -1 line 0 comments Download
M ui/events/gesture_detection/motion_event_generic_unittest.cc View 3 chunks +28 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
sky
5 years, 9 months ago (2015-03-25 18:23:40 UTC) #1
tdresser
On 2015/03/25 18:23:40, sky wrote: LGTM. I'm not super fond of enabling mutation of MotionEventAura ...
5 years, 9 months ago (2015-03-25 18:38:03 UTC) #2
sky
This will be used in html_viewer.
5 years, 9 months ago (2015-03-25 19:15:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035793003/1
5 years, 9 months ago (2015-03-25 19:17:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 19:52:24 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 19:53:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1eb0a7e1062b0ea684727df4d61c55a75fe4a87
Cr-Commit-Position: refs/heads/master@{#322218}

Powered by Google App Engine
This is Rietveld 408576698