Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1035633002: Revert of ChannelMojo: Let MessagePipeReader wait "peer closed" signal as well. (Closed)

Created:
5 years, 9 months ago by tkent
Modified:
5 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ChannelMojo: Let MessagePipeReader wait "peer closed" signal as well. (patchset #2 id:20001 of https://codereview.chromium.org/1023043002/) Reason for revert: speculative revert for "Too many open files" on various Mac bots. e.g. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/17511/steps/webkit_tests/logs/stdio Original issue's description: > ChannelMojo: Let MessagePipeReader wait "peer closed" signal as well. > > This CL adds MOJO_SIGNAL_PEER_CLOSED for the MessagePipeReader's > waiting bits. Without this, PRECONDITION_FAILED error can be notified > at the end of the channel lifetime, and the browser process misinterprets > it as a renderer crash, which results sadface screen. > > This rarely happens and is reproduced only with some underpowered CPU > with excessive pressure. So we cannot have any reliable test. > > BUG=466814 > R=viettrungluu@chromium.org > > Committed: https://crrev.com/29d88220e88d21deaf6856b7ded300fa06ab94d3 > Cr-Commit-Position: refs/heads/master@{#322094} TBR=viettrungluu@chromium.org,morrita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466814 Committed: https://crrev.com/5eab51f762a444966a1914cd15de196ee0d801a9 Cr-Commit-Position: refs/heads/master@{#322112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M ipc/mojo/ipc_message_pipe_reader.cc View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Created Revert of ChannelMojo: Let MessagePipeReader wait "peer closed" signal as well.
5 years, 9 months ago (2015-03-25 04:38:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035633002/1
5 years, 9 months ago (2015-03-25 04:39:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 04:40:25 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 04:41:10 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5eab51f762a444966a1914cd15de196ee0d801a9
Cr-Commit-Position: refs/heads/master@{#322112}

Powered by Google App Engine
This is Rietveld 408576698