Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

Issue 1035623002: bindings: Use Maybe APIs in ScriptPromise (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptPromise.cpp ('k') | Source/bindings/core/v8/ScriptValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
diff --git a/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp b/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
index c52acfedf6a76658e3747dabd4add422c427c1f9..487e1c20b4984ae1738379110c57444d4614a622 100644
--- a/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
+++ b/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
@@ -37,22 +37,24 @@ ScriptPromise ScriptPromisePropertyBase::promise(DOMWrapperWorld& world)
return ScriptPromise();
v8::HandleScope handleScope(m_isolate);
- v8::Handle<v8::Context> context = toV8Context(executionContext(), world);
+ v8::Local<v8::Context> context = toV8Context(executionContext(), world);
if (context.IsEmpty())
return ScriptPromise();
ScriptState* scriptState = ScriptState::from(context);
ScriptState::Scope scope(scriptState);
- v8::Handle<v8::Object> wrapper = ensureHolderWrapper(scriptState);
+ v8::Local<v8::Object> wrapper = ensureHolderWrapper(scriptState);
ASSERT(wrapper->CreationContext() == context);
- v8::Handle<v8::Value> cachedPromise = V8HiddenValue::getHiddenValue(m_isolate, wrapper, promiseName());
+ v8::Local<v8::Value> cachedPromise = V8HiddenValue::getHiddenValue(m_isolate, wrapper, promiseName());
if (!cachedPromise.IsEmpty())
return ScriptPromise(scriptState, cachedPromise);
// Create and cache the Promise
- v8::Handle<v8::Promise::Resolver> resolver = v8::Promise::Resolver::New(m_isolate);
- v8::Handle<v8::Promise> promise = resolver->GetPromise();
+ v8::Local<v8::Promise::Resolver> resolver;
+ if (!v8::Promise::Resolver::New(context).ToLocal(&resolver))
+ return ScriptPromise();
+ v8::Local<v8::Promise> promise = resolver->GetPromise();
V8HiddenValue::setHiddenValue(m_isolate, wrapper, promiseName(), promise);
switch (m_state) {
@@ -107,15 +109,16 @@ void ScriptPromisePropertyBase::resetBase()
void ScriptPromisePropertyBase::resolveOrRejectInternal(v8::Handle<v8::Promise::Resolver> resolver)
{
+ v8::Local<v8::Context> context = resolver->CreationContext();
switch (m_state) {
case Pending:
ASSERT_NOT_REACHED();
break;
case Resolved:
- resolver->Resolve(resolvedValue(m_isolate, resolver->CreationContext()->Global()));
+ resolver->Resolve(context, resolvedValue(m_isolate, context->Global()));
break;
case Rejected:
- resolver->Reject(rejectedValue(m_isolate, resolver->CreationContext()->Global()));
+ resolver->Reject(context, rejectedValue(m_isolate, context->Global()));
break;
}
}
« no previous file with comments | « Source/bindings/core/v8/ScriptPromise.cpp ('k') | Source/bindings/core/v8/ScriptValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698