bindings: Use Maybe APIs in ScriptPromise

Source/bindings/core/v8/ScriptValue.h

 /*
  * Copyright (C) 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 46 matching lines @@
     {
         return NativeValueTraits<T>::nativeValue(isolate, value.v8Value(), exceptionState, arguments...);
     }
 
     ScriptValue() { }
 
     ScriptValue(ScriptState* scriptState, v8::Handle<v8::Value> value)
         : m_scriptState(scriptState)
         , m_value(value.IsEmpty() ? nullptr : SharedPersistent<v8::Value>::create(value, scriptState->isolate()))
     {
         ASSERT(isEmpty() || m_scriptState);

[haraken, 2015/03/25 05:08:29]

I'm just wondering but is it valid that m_scriptState is 0 here? (You can
address this in a follow-up.)

[bashi, 2015/03/25 07:25:32]

You mean we should just ASSERT(m_scriptState)? I think it makes sense.

[bashi, 2015/03/25 07:35:01]

It seems that some tests fail when dropping isEmpty(), so I'll keep the current
condition.

[haraken, 2015/03/25 09:04:23]

Thanks for the investigation. Yeah, if the value is empty, the value doesn't
need to be associated with any ScriptState, so allowing no ScriptState when the
value is empty would make sense. Sorry about the noise.

     }
 
+    template <typename T>
+    ScriptValue(ScriptState* scriptState, v8::MaybeLocal<T> value)
+        : m_scriptState(scriptState)
+        , m_value(value.IsEmpty() ? nullptr : SharedPersistent<v8::Value>::create(value.ToLocalChecked(), scriptState->isolate()))
+    {
+        ASSERT(isEmpty() || m_scriptState);

[haraken, 2015/03/25 05:08:29]

Ditto.

+    }
+
     ScriptValue(const ScriptValue& value)
         : m_scriptState(value.m_scriptState)
         , m_value(value.m_value)
     {
         ASSERT(isEmpty() || m_scriptState);
     }
 
     ScriptState* scriptState() const
     {
         return m_scriptState.get();
     }
 
     v8::Isolate* isolate() const
     {
         return m_scriptState ? m_scriptState->isolate() : v8::Isolate::GetCurrent();
     }
 
+    v8::Local<v8::Context> context() const
+    {
+        ASSERT(m_scriptState.get());
+        return m_scriptState->context();
+    }
+
     ScriptValue& operator=(const ScriptValue& value)
     {
         if (this != &value) {
             m_scriptState = value.m_scriptState;
             m_value = value.m_value;
         }
         return *this;
     }
 
     bool operator==(const ScriptValue& value) const
@@ skipping 61 matching lines @@
     static ScriptValue createNull(ScriptState*);
 
 private:
     RefPtr<ScriptState> m_scriptState;
     RefPtr<SharedPersistent<v8::Value>> m_value;
 };
 
 } // namespace blink
 
 #endif // ScriptValue_h