Check nullity in FullscreenHtmlApiHandler

Check nullity in FullscreenHtmlApiHandler

BUG=470116
Committed: https://crrev.com/0e07705504836d8647f93931a4b78c04e11166b1
Cr-Commit-Position: refs/heads/master@{#322205}

[Changwan Ryu, 2015-03-25 00:48:55]

changwan@chromium.org changed reviewers:
+ dtrainor@chromium.org

[Changwan Ryu, 2015-03-25 01:38:14]

changwan@chromium.org changed reviewers:
+ aruslan@chromium.org, tedchoc@chromium.org

[Ted C, 2015-03-25 15:31:18]

lgtm

https://codereview.chromium.org/1035603002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java
(right):

https://codereview.chromium.org/1035603002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java:273:
// Checks nullity since contentViewCore may be destroyed at this point.
this comment is a bit confusing.  WebContents isn't actually owned by the
ContentViewCore, so it being destroyed isn't the main issue.  Granted, when a
WebContents is destroyed, the ContentViewCore is as well (but it's more driven
by the WebContents destruction).

Maybe just:

"getWebContents() will return null if contentViewCore has been destroyed"

The "Check nullity" is just describing the line of code, and I think that is
self explanatory enough.

[Changwan Ryu, 2015-03-25 17:09:53]

https://codereview.chromium.org/1035603002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java
(right):

https://codereview.chromium.org/1035603002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java:273:
// Checks nullity since contentViewCore may be destroyed at this point.
On 2015/03/25 15:31:18, Ted C wrote:
> this comment is a bit confusing.  WebContents isn't actually owned by the
> ContentViewCore, so it being destroyed isn't the main issue.  Granted, when a
> WebContents is destroyed, the ContentViewCore is as well (but it's more driven
> by the WebContents destruction).
> 
> Maybe just:
> 
> "getWebContents() will return null if contentViewCore has been destroyed"
> 
> The "Check nullity" is just describing the line of code, and I think that is
> self explanatory enough.

Done.

[David Trainor- moved to gerrit, 2015-03-25 17:41:15]

lgtm

[Changwan Ryu, 2015-03-25 18:33:41]

The CQ bit was checked by changwan@chromium.org

[Changwan Ryu, 2015-03-25 18:33:41]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1035603002/#ps20001
(title: "changed comment")

[commit-bot: I haz the power, 2015-03-25 18:35:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035603002/20001

[commit-bot: I haz the power, 2015-03-25 19:14:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-25 19:14:30]

Patchset 2 (id:??) landed as
https://crrev.com/0e07705504836d8647f93931a4b78c04e11166b1
Cr-Commit-Position: refs/heads/master@{#322205}