Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: Source/core/dom/SpaceSplitString.h

Issue 1035573005: Change a bool type to an enum type in constructor argument of SpaceSplitString. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Draft Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/SpaceSplitString.h
diff --git a/Source/core/dom/SpaceSplitString.h b/Source/core/dom/SpaceSplitString.h
index c5f47adb6c6173cd23969dcff3e9af3013490683..12fc5c6cf2181314464f86aa8d45c520d837798a 100644
--- a/Source/core/dom/SpaceSplitString.h
+++ b/Source/core/dom/SpaceSplitString.h
@@ -27,14 +27,19 @@
namespace blink {
+enum SplitStringCase {
Mike West 2015/03/26 19:33:05 I'd prefer you to move this into SpaceSplitString
+ ShouldNotFoldCase,
+ ShouldFoldCase
+};
+
class SpaceSplitString {
public:
SpaceSplitString() { }
- SpaceSplitString(const AtomicString& string, bool shouldFoldCase) { set(string, shouldFoldCase); }
+ SpaceSplitString(const AtomicString& string, SplitStringCase splitStringCase) { set(string, splitStringCase); }
bool operator!=(const SpaceSplitString& other) const { return m_data != other.m_data; }
- void set(const AtomicString&, bool shouldFoldCase);
+ void set(const AtomicString&, SplitStringCase);
void clear() { m_data.clear(); }
bool contains(const AtomicString& string) const { return m_data && m_data->contains(string); }

Powered by Google App Engine
This is Rietveld 408576698