Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: Source/core/dom/SpaceSplitString.cpp

Issue 1035573005: Change a bool type to an enum type in constructor argument of SpaceSplitString. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Draft Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/SpaceSplitString.cpp
diff --git a/Source/core/dom/SpaceSplitString.cpp b/Source/core/dom/SpaceSplitString.cpp
index 45472171e0394c16bc281c1e38f5d48a810e731a..49033e27672564a6c4085b91efd5c30de530a28a 100644
--- a/Source/core/dom/SpaceSplitString.cpp
+++ b/Source/core/dom/SpaceSplitString.cpp
@@ -151,7 +151,7 @@ SpaceSplitString::DataMap& SpaceSplitString::sharedDataMap()
return map;
}
-void SpaceSplitString::set(const AtomicString& inputString, bool shouldFoldCase)
+void SpaceSplitString::set(const AtomicString& inputString, SplitStringCase splitStringCase)
{
if (inputString.isNull()) {
clear();
@@ -159,7 +159,7 @@ void SpaceSplitString::set(const AtomicString& inputString, bool shouldFoldCase)
}
String string(inputString.string());
- if (shouldFoldCase && hasNonASCIIOrUpper(string))
+ if ((splitStringCase == ShouldFoldCase) && hasNonASCIIOrUpper(string))
Mike West 2015/03/26 19:33:05 Nit: You don't need the extra () here.
string = string.foldCase();
m_data = Data::create(AtomicString(string));

Powered by Google App Engine
This is Rietveld 408576698