[Sync] Replace AttachmentIdSet with AttachmentIdList in interfaces.

sync/syncable/directory_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/syncable/directory_unittest.h"
 
 #include "base/strings/stringprintf.h"
 #include "base/test/values_test_util.h"
 #include "sync/internal_api/public/base/attachment_id_proto.h"
 #include "sync/syncable/syncable_proto_util.h"
@@ skipping 1766 matching lines @@
   sync_pb::AttachmentMetadataRecord* record = attachment_metadata.add_record();
   *record->mutable_id() = attachment_id_proto;
   const Id id1 = TestIdFactory::FromNumber(-1);
   const Id id2 = TestIdFactory::FromNumber(-2);
   CreateEntryWithAttachmentMetadata(
       PREFERENCES, "some entry", id1, attachment_metadata);
   CreateEntryWithAttachmentMetadata(
       PREFERENCES, "some other entry", id2, attachment_metadata);
 
   // See that Directory reports that this attachment is not on the server.
-  AttachmentIdSet id_set;
+  AttachmentIdList ids;
   {
     ReadTransaction trans(FROM_HERE, dir().get());
-    dir()->GetAttachmentIdsToUpload(&trans, PREFERENCES, &id_set);
+    dir()->GetAttachmentIdsToUpload(&trans, PREFERENCES, &ids);
   }
-  ASSERT_EQ(1U, id_set.size());
-  ASSERT_EQ(attachment_id, *id_set.begin());
+  ASSERT_EQ(1U, ids.size());
+  ASSERT_EQ(attachment_id, *ids.begin());
 
   // Call again, but this time with a ModelType for which there are no entries.
   // See that Directory correctly reports that there are none.
   {
     ReadTransaction trans(FROM_HERE, dir().get());
-    dir()->GetAttachmentIdsToUpload(&trans, PASSWORDS, &id_set);
+    dir()->GetAttachmentIdsToUpload(&trans, PASSWORDS, &ids);
   }
-  ASSERT_TRUE(id_set.empty());
+  ASSERT_TRUE(ids.empty());
 
   // Now, mark the attachment as "on the server" via entry_1.
   {
     WriteTransaction trans(FROM_HERE, UNITTEST, dir().get());
     MutableEntry entry_1(&trans, GET_BY_ID, id1);
     entry_1.MarkAttachmentAsOnServer(attachment_id_proto);
   }
 
   // See that Directory no longer reports that this attachment is not on the
   // server.
   {
     ReadTransaction trans(FROM_HERE, dir().get());
-    dir()->GetAttachmentIdsToUpload(&trans, PREFERENCES, &id_set);
+    dir()->GetAttachmentIdsToUpload(&trans, PREFERENCES, &ids);
   }
-  ASSERT_TRUE(id_set.empty());
+  ASSERT_TRUE(ids.empty());
 }
 
 // Verify that the directory accepts entries with unset parent ID.
 TEST_F(SyncableDirectoryTest, MutableEntry_ImplicitParentId) {
   TestIdFactory id_factory;
   const Id root_id = TestIdFactory::root();
   const Id p_root_id = id_factory.NewServerId();
   const Id a_root_id = id_factory.NewServerId();
   const Id item1_id = id_factory.NewServerId();
   const Id item2_id = id_factory.NewServerId();
@@ skipping 49 matching lines @@
     ASSERT_EQ(1, p_root.GetTotalNodeCount() - 1);
     Entry a_root(&trans, GET_BY_ID, a_root_id);
     ASSERT_EQ(item2_id, a_root.GetFirstChildId());
     ASSERT_EQ(1, a_root.GetTotalNodeCount() - 1);
   }
 }
 
 }  // namespace syncable
 
 }  // namespace syncer