Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: sync/syncable/directory.h

Issue 1035573002: [Sync] Replace AttachmentIdSet with AttachmentIdList in interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes after Nick's feedback. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sync/internal_api/read_transaction.cc ('k') | sync/syncable/directory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SYNC_SYNCABLE_DIRECTORY_H_ 5 #ifndef SYNC_SYNCABLE_DIRECTORY_H_
6 #define SYNC_SYNCABLE_DIRECTORY_H_ 6 #define SYNC_SYNCABLE_DIRECTORY_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 void GetMetahandlesByAttachmentId( 410 void GetMetahandlesByAttachmentId(
411 BaseTransaction* trans, 411 BaseTransaction* trans,
412 const sync_pb::AttachmentIdProto& attachment_id_proto, 412 const sync_pb::AttachmentIdProto& attachment_id_proto,
413 Metahandles* result); 413 Metahandles* result);
414 414
415 // Change entry to not dirty. Used in special case when we don't want to 415 // Change entry to not dirty. Used in special case when we don't want to
416 // persist modified entry on disk. e.g. SyncBackupManager uses this to 416 // persist modified entry on disk. e.g. SyncBackupManager uses this to
417 // preserve sync preferences in DB on disk. 417 // preserve sync preferences in DB on disk.
418 void UnmarkDirtyEntry(WriteTransaction* trans, Entry* entry); 418 void UnmarkDirtyEntry(WriteTransaction* trans, Entry* entry);
419 419
420 // Clears |id_set| and fills it with the ids of attachments that need to be 420 // Clears |ids| and fills it with the ids of attachments that need to be
421 // uploaded to the sync server. 421 // uploaded to the sync server.
422 void GetAttachmentIdsToUpload(BaseTransaction* trans, 422 void GetAttachmentIdsToUpload(BaseTransaction* trans,
423 ModelType type, 423 ModelType type,
424 AttachmentIdSet* id_set); 424 AttachmentIdList* ids);
425 425
426 private: 426 private:
427 struct Kernel { 427 struct Kernel {
428 // |delegate| must not be NULL. |transaction_observer| must be 428 // |delegate| must not be NULL. |transaction_observer| must be
429 // initialized. 429 // initialized.
430 Kernel(const std::string& name, const KernelLoadInfo& info, 430 Kernel(const std::string& name, const KernelLoadInfo& info,
431 DirectoryChangeDelegate* delegate, 431 DirectoryChangeDelegate* delegate,
432 const WeakHandle<TransactionObserver>& transaction_observer); 432 const WeakHandle<TransactionObserver>& transaction_observer);
433 433
434 ~Kernel(); 434 ~Kernel();
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
647 // are deleted in native models as well. 647 // are deleted in native models as well.
648 scoped_ptr<DeleteJournal> delete_journal_; 648 scoped_ptr<DeleteJournal> delete_journal_;
649 649
650 DISALLOW_COPY_AND_ASSIGN(Directory); 650 DISALLOW_COPY_AND_ASSIGN(Directory);
651 }; 651 };
652 652
653 } // namespace syncable 653 } // namespace syncable
654 } // namespace syncer 654 } // namespace syncer
655 655
656 #endif // SYNC_SYNCABLE_DIRECTORY_H_ 656 #endif // SYNC_SYNCABLE_DIRECTORY_H_
OLDNEW
« no previous file with comments | « sync/internal_api/read_transaction.cc ('k') | sync/syncable/directory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698