Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1035533006: Unify the QUIC client classes. (Closed)

Created:
5 years, 9 months ago by Ryan Hamilton
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify the QUIC client classes. Committed: https://crrev.com/ed113b20e8e8658be2bfc42faa093d8368e60900 Cr-Commit-Position: refs/heads/master@{#322323}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove associated tests #

Patch Set 3 : ssize_t #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -686 lines) Patch
M net/BUILD.gn View 3 chunks +4 lines, -8 lines 0 comments Download
M net/net.gyp View 3 chunks +4 lines, -8 lines 0 comments Download
M net/net.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_client.h View 4 chunks +6 lines, -6 lines 0 comments Download
M net/tools/quic/quic_simple_client.cc View 5 chunks +16 lines, -9 lines 0 comments Download
D net/tools/quic/quic_simple_client_session.h View 1 chunk +0 lines, -72 lines 0 comments Download
D net/tools/quic/quic_simple_client_session.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D net/tools/quic/quic_simple_client_session_test.cc View 1 1 chunk +0 lines, -146 lines 0 comments Download
D net/tools/quic/quic_simple_client_stream.h View 1 chunk +0 lines, -92 lines 0 comments Download
D net/tools/quic/quic_simple_client_stream.cc View 1 chunk +0 lines, -142 lines 0 comments Download
D net/tools/quic/quic_simple_client_stream_test.cc View 1 1 chunk +0 lines, -115 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Ryan Hamilton
5 years, 9 months ago (2015-03-25 22:56:22 UTC) #2
ramant (doing other things)
Changes look ok to me. Shouldn't we delete net/tools/quic/quic_simple_client_session_test.cc? thanks raman https://codereview.chromium.org/1035533006/diff/1/net/tools/quic/quic_simple_client_stream.h File net/tools/quic/quic_simple_client_stream.h (left): ...
5 years, 9 months ago (2015-03-26 00:09:19 UTC) #3
Ryan Hamilton
On 2015/03/26 00:09:19, ramant wrote: > Changes look ok to me. Shouldn't we delete > ...
5 years, 9 months ago (2015-03-26 00:33:36 UTC) #4
ramant (doing other things)
lgtm Thanks much.
5 years, 9 months ago (2015-03-26 00:35:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035533006/20001
5 years, 9 months ago (2015-03-26 00:50:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/67692)
5 years, 9 months ago (2015-03-26 01:28:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035533006/40001
5 years, 9 months ago (2015-03-26 03:36:02 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/36789) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-26 03:40:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035533006/60001
5 years, 9 months ago (2015-03-26 03:53:25 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 9 months ago (2015-03-26 04:54:13 UTC) #19
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 04:55:29 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ed113b20e8e8658be2bfc42faa093d8368e60900
Cr-Commit-Position: refs/heads/master@{#322323}

Powered by Google App Engine
This is Rietveld 408576698