Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1035533004: PPC: Switch full-codegen from StackHandlers to handler table. (Closed)

Created:
5 years, 9 months ago by michael_dawson
Modified:
5 years, 9 months ago
Reviewers:
MTBrandyberry, r=mbrandy, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Switch full-codegen from StackHandlers to handler table. Port 38a719f965d0a83ddac04392d5b9c5abe214281c Original commit message: This switches full-codegen to no longer push and pop StackHandler markers onto the operand stack, but relies on a range-based handler table instead. We only use StackHandlers in JSEntryStubs to mark the transition from C to JS code. Note that this makes deoptimization and OSR from within any try-block work out of the box, makes the non-exception paths faster and should overall be neutral on the memory footprint (pros). On the other hand it makes the exception paths slower and actually throwing and exception more expensive (cons). TEST=cctest/test-run-jsexceptions/DeoptTry R=yangguo@chromium.org, R=mbrandy@us.ibm.com BUG= Committed: https://crrev.com/918ec32d7b6917358131d1a6f463c6b442966455 Cr-Commit-Position: refs/heads/master@{#27453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -67 lines) Patch
M src/ppc/code-stubs-ppc.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 5 chunks +8 lines, -33 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +8 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
michael_dawson
Next PPC port
5 years, 9 months ago (2015-03-25 16:37:40 UTC) #1
MTBrandyberry
On 2015/03/25 16:37:40, michael_dawson wrote: > Next PPC port lgtm
5 years, 9 months ago (2015-03-25 17:04:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035533004/1
5 years, 9 months ago (2015-03-25 17:04:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 17:26:39 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 17:26:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/918ec32d7b6917358131d1a6f463c6b442966455
Cr-Commit-Position: refs/heads/master@{#27453}

Powered by Google App Engine
This is Rietveld 408576698