Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1035533003: Oilpan: fix build++ after r192490. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build++ after r192490. TBR=oilpan-reviews BUG=463435 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192503

Patch Set 1 #

Patch Set 2 : provide null trace() for non-oilpan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M Source/core/dom/DOMSettableTokenList.h View 1 3 chunks +7 lines, -3 lines 0 comments Download
M Source/core/dom/DOMSettableTokenList.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/HTMLIFrameElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLIFrameElement.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sof
please take a look.
5 years, 9 months ago (2015-03-25 07:09:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035533003/20001
5 years, 9 months ago (2015-03-25 07:24:37 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=192503
5 years, 9 months ago (2015-03-25 07:25:19 UTC) #4
haraken
5 years, 9 months ago (2015-03-25 07:28:54 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698