Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1035523006: Updating PESQ binary to one that does not require a side-by-side config. (Closed)

Created:
5 years, 9 months ago by phoglund_chromium
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating PESQ binary to one that does not require a side-by-side config. In other words, the old binary was built in debug, which requires a certain visual studio to be installed, whereas the new one is built in release. BUG=468779 Committed: https://crrev.com/ef57357811d9c9d624515788e5ad58bd64845686 Cr-Commit-Position: refs/heads/master@{#322578}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/test/data/webrtc/resources/tools/README View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/webrtc/resources/tools/win/pesq.exe.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
phoglund_chromium
5 years, 9 months ago (2015-03-27 13:05:56 UTC) #2
kjellander_chromium
lgtm
5 years, 9 months ago (2015-03-27 13:24:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035523006/20001
5 years, 9 months ago (2015-03-27 13:33:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-27 14:59:51 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 15:00:47 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef57357811d9c9d624515788e5ad58bd64845686
Cr-Commit-Position: refs/heads/master@{#322578}

Powered by Google App Engine
This is Rietveld 408576698