src/heap/heap.h - Issue 1035523005: Serializer: ensure unique script ids when deserializing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.h

Issue 1035523005: Serializer: ensure unique script ids when deserializing. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/heap.h

diff --git a/src/heap/heap.h b/src/heap/heap.h

index 5c276e9581c5fa2aac11a33db53cd7dd96a444b5..8e4952e8a83fb5e2d577a42f50eef38af99c16e9 100644

--- a/src/heap/heap.h

+++ b/src/heap/heap.h

@@ -1349,6 +1349,14 @@ class Heap {

return seed;

}

+ Smi* NextScriptId() {

+ int next_id = last_script_id()->value() + 1;

+ if (!Smi::IsValid(next_id) || next_id < 0) next_id = 1;

jochen (gone - plz use gerrit) 2015/03/26 08:00:22 when this happens, we're in trouble, right? maybe

+ Smi* next_id_smi = Smi::FromInt(next_id);

+ set_last_script_id(next_id_smi);

+ return next_id_smi;

+ }

void SetArgumentsAdaptorDeoptPCOffset(int pc_offset) {

DCHECK(arguments_adaptor_deopt_pc_offset() == Smi::FromInt(0));

set_arguments_adaptor_deopt_pc_offset(Smi::FromInt(pc_offset));

« no previous file with comments | « src/factory.cc ('k') | src/serialize.cc » ('j') | no next file with comments »