Serializer: ensure unique script ids when deserializing.

Serializer: ensure unique script ids when deserializing.

R=jochen@chromium.org

Committed: https://crrev.com/ed9191221b6f68f25d9bfc2050cbff47e6bcb885
Cr-Commit-Position: refs/heads/master@{#27471}

[jochen (gone - plz use gerrit), 2015-03-26 08:00:22]

lgtm

https://codereview.chromium.org/1035523005/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1035523005/diff/1/src/heap/heap.h#newcode1354
src/heap/heap.h:1354: if (!Smi::IsValid(next_id) || next_id < 0) next_id = 1;
when this happens, we're in trouble, right? maybe add notreached?

[Yang, 2015-03-26 08:04:00]

On 2015/03/26 08:00:22, jochen wrote:
> lgtm
> 
> https://codereview.chromium.org/1035523005/diff/1/src/heap/heap.h
> File src/heap/heap.h (right):
> 
> https://codereview.chromium.org/1035523005/diff/1/src/heap/heap.h#newcode1354
> src/heap/heap.h:1354: if (!Smi::IsValid(next_id) || next_id < 0) next_id = 1;
> when this happens, we're in trouble, right? maybe add notreached?

Well, not exactly in trouble. The debugger would act subtly weird. I don't think
we use the id for anything else.

So far this bug has eluded me because the debugger tests have the debugger
activated upon startup, so that the code serializer is disabled. I'm introducing
a test case [0] where the debugger is activated late, so we may run into this
issue.

[0] https://codereview.chromium.org/998253005/

[Yang, 2015-03-26 08:04:09]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-03-26 08:04:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035523005/1

[commit-bot: I haz the power, 2015-03-26 08:29:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-26 08:29:16]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Yang, 2015-03-26 09:09:26]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-03-26 09:09:27]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1035523005/#ps20001
(title: "rebase and fix")

[commit-bot: I haz the power, 2015-03-26 09:09:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035523005/20001

[commit-bot: I haz the power, 2015-03-26 09:20:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-26 09:20:18]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Yang, 2015-03-26 09:29:06]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-03-26 09:29:07]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1035523005/#ps40001
(title: "fix test")

[commit-bot: I haz the power, 2015-03-26 09:29:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035523005/40001

[commit-bot: I haz the power, 2015-03-26 09:50:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-26 09:51:01]

Patchset 3 (id:??) landed as
https://crrev.com/ed9191221b6f68f25d9bfc2050cbff47e6bcb885
Cr-Commit-Position: refs/heads/master@{#27471}