Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 1035523004: [6/8][Ozone-Drm] Fix lookup for DRM property values (Closed)

Created:
5 years, 9 months ago by dnicoara
Modified:
5 years, 8 months ago
Reviewers:
spang
CC:
chromium-reviews, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@async-content-protection5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-Drm] Fix lookup for DRM property values Property IDs are not indexes, so we need to iterate over the properties to find the correct one. BUG=442317 Committed: https://crrev.com/db26cbf00e794d7de3c1b98a505b220dd99d1a4b Cr-Commit-Position: refs/heads/master@{#325238}

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc View 1 2 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
dnicoara
5 years, 9 months ago (2015-03-26 17:47:47 UTC) #2
spang
please CC me on the whole series next time
5 years, 9 months ago (2015-03-26 17:49:02 UTC) #3
spang
https://codereview.chromium.org/1035523004/diff/1/ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc File ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc (right): https://codereview.chromium.org/1035523004/diff/1/ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc#newcode351 ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc:351: for (int prop_idx = 0; prop_idx < connector->count_props; ++prop_idx) ...
5 years, 9 months ago (2015-03-26 17:56:29 UTC) #4
dnicoara
https://codereview.chromium.org/1035523004/diff/1/ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc File ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc (right): https://codereview.chromium.org/1035523004/diff/1/ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc#newcode351 ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc:351: for (int prop_idx = 0; prop_idx < connector->count_props; ++prop_idx) ...
5 years, 8 months ago (2015-04-14 21:57:17 UTC) #5
dnicoara
On 2015/03/26 17:49:02, spang wrote: > please CC me on the whole series next time ...
5 years, 8 months ago (2015-04-14 21:57:29 UTC) #6
spang
lgtm
5 years, 8 months ago (2015-04-14 21:58:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035523004/20001
5 years, 8 months ago (2015-04-15 13:47:01 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 13:49:59 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 13:51:07 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db26cbf00e794d7de3c1b98a505b220dd99d1a4b
Cr-Commit-Position: refs/heads/master@{#325238}

Powered by Google App Engine
This is Rietveld 408576698