SkPDF: skpdfdocument and skpdfpage use skpdfdevice in a const way

src/pdf/SkPDFDevice.h

Index: src/pdf/SkPDFDevice.h
diff --git a/src/pdf/SkPDFDevice.h b/src/pdf/SkPDFDevice.h
index a90ea115c1b69951e0a48f9dd1e7961a1c5f6329..425362f7058e8b149ea382dd2f93910829cadb24 100644
--- a/src/pdf/SkPDFDevice.h
+++ b/src/pdf/SkPDFDevice.h
@@ -35,7 +35,6 @@ class SkPDFResourceDict;
 class SkPDFShader;
 class SkPDFStream;
 class SkRRect;
-template <typename T> class SkTSet;
 
 // Private classes.
 struct ContentEntry;
@@ -138,9 +137,9 @@ public:
 
     // PDF specific methods.
 
-    /** Returns the resource dictionary for this device.
+    /** Create the resource dictionary for this device.
      */
-    SkPDFResourceDict* getResourceDict();
+    SkPDFResourceDict* createResourceDict() const;
 
     /** Get the fonts used on this device.
      */
@@ -150,7 +149,7 @@ public:
      *  @param dict  Dictionary to add destinations to.
      *  @param page  The PDF object representing the page for this device.
      */
-    void appendDestinations(SkPDFDict* dict, SkPDFObject* page);
+    void appendDestinations(SkPDFDict* dict, SkPDFObject* page) const;
 
     /** Returns a copy of the media box for this device. The caller is required
      *  to unref() this when it is finished.
@@ -198,7 +197,6 @@ private:
     SkClipStack fExistingClipStack;
     SkRegion fExistingClipRegion;
     SkPDFArray* fAnnotations;
-    SkPDFResourceDict* fResourceDict;

[mtklein, 2015/03/25 13:16:48]

Does this mean we're dropping some sort of caching / reuse?

     SkTDArray<NamedDestination*> fNamedDestinations;
 
     SkTDArray<SkPDFGraphicState*> fGraphicStateResources;