SkPDF: skpdfdocument and skpdfpage use skpdfdevice in a const way

SkPDF: skpdfdocument and skpdfpage use skpdfdevice in a const way

BUG=skia:3585
Committed: https://skia.googlesource.com/skia/+/6d622703e578eddc64ab4e3340d0ab0033268799

[hal.canary, 2015-03-24 21:27:45]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-03-24 21:28:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035513003/1

[commit-bot: I haz the power, 2015-03-24 21:28:01]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-03-25 03:28 UTC

[hal.canary, 2015-03-24 21:28:24]

halcanary@google.com changed reviewers:
+ mtklein@google.com

[hal.canary, 2015-03-24 21:28:24]

PTAL

[commit-bot: I haz the power, 2015-03-25 03:28:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-25 03:28:07]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[mtklein, 2015-03-25 13:16:48]

https://codereview.chromium.org/1035513003/diff/40001/src/pdf/SkPDFDevice.h
File src/pdf/SkPDFDevice.h (left):

https://codereview.chromium.org/1035513003/diff/40001/src/pdf/SkPDFDevice.h#o...
src/pdf/SkPDFDevice.h:201: SkPDFResourceDict* fResourceDict;
Does this mean we're dropping some sort of caching / reuse?

[hal.canary, 2015-03-25 15:01:27]

On 2015/03/25 13:16:48, mtklein wrote:
> https://codereview.chromium.org/1035513003/diff/40001/src/pdf/SkPDFDevice.h
> File src/pdf/SkPDFDevice.h (left):
> 
>
https://codereview.chromium.org/1035513003/diff/40001/src/pdf/SkPDFDevice.h#o...
> src/pdf/SkPDFDevice.h:201: SkPDFResourceDict* fResourceDict;
> Does this mean we're dropping some sort of caching / reuse?

If you come in via the public API, you won't ever use the caching anyways.

[mtklein, 2015-03-25 15:14:56]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-03-25 15:14:57]

lgtm

[commit-bot: I haz the power, 2015-03-25 15:15:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035513003/40001

[commit-bot: I haz the power, 2015-03-25 15:15:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-25 15:15:11]

Failed to apply patch for src/pdf/SkPDFDocument.h:
While running git apply --index -3 -p1;
  error: patch failed: src/pdf/SkPDFDocument.h:11
  Falling back to three-way merge...
  Applied patch to 'src/pdf/SkPDFDocument.h' with conflicts.
  U src/pdf/SkPDFDocument.h

Patch:       src/pdf/SkPDFDocument.h
Index: src/pdf/SkPDFDocument.h
diff --git a/src/pdf/SkPDFDocument.h b/src/pdf/SkPDFDocument.h
index
e4c0521cbe0472bea31f0f783b1cbdbf0eee2568..c49e6397a1ea76c90cf0c194d0aecc875f2d3f64
100644
--- a/src/pdf/SkPDFDocument.h
+++ b/src/pdf/SkPDFDocument.h
@@ -11,17 +11,10 @@
 #define SkPDFDocument_DEFINED
 
 #include "SkAdvancedTypefaceMetrics.h"
-#include "SkRefCnt.h"
+#include "SkPDFDevice.h"
 #include "SkTDArray.h"
-#include "SkTemplates.h"
 
-class SkPDFCatalog;
-class SkPDFDevice;
-class SkPDFDict;
-class SkPDFPage;
-class SkPDFObject;
 class SkWStream;
-template <typename T> class SkTSet;
 
 /** \class SkPDFDocument
 
@@ -46,7 +39,7 @@ public:
      *
      *  @param pdfDevice The page to add to this document.
      */
-    bool appendPage(SkPDFDevice* pdfDevice) {
+    bool appendPage(const SkPDFDevice* pdfDevice) {
         fPageDevices.push(SkRef(pdfDevice));
         return true;
     }
@@ -59,7 +52,7 @@ public:
         int* notEmbedddableCount) const;
 
 private:
-    SkTDArray<SkPDFDevice*> fPageDevices;
+    SkTDArray<const SkPDFDevice*> fPageDevices;
 };
 
 #endif

[hal.canary, 2015-03-25 15:26:02]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-03-25 15:26:03]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1035513003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-03-25 15:26:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035513003/60001

[commit-bot: I haz the power, 2015-03-25 15:45:47]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6d622703e578eddc64ab4e3340d0ab0033268799