Files.app: Switch analytics to use the chrome version, not the app version, for tracking.

Files.app: Switch analytics to use the chrome version, not the app version, for tracking.

The files.app version in the manifest is not regularly updated.  We'll get more accurate version info by using the chrome major release version.

BUG=469258
Committed: https://crrev.com/7d90893641c3024633c1274dd7a1d83af46482fc
Cr-Commit-Position: refs/heads/master@{#322106}

[Ben Kwa, 2015-03-24 19:48:46]

kenobi@chromium.org changed reviewers:
+ mtomasz@chromium.org, smckay@chromium.org

[Steve McKay, 2015-03-24 20:07:58]

LGTM w/ nit.

https://codereview.chromium.org/1035483004/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/common/js/metrics.js (right):

https://codereview.chromium.org/1035483004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/common/js/metrics.js:57: metrics.analytics_ =
analytics.getService('Files app');
I'd rather know if this condition is ever happening. Let's make this version
'0.0'.

[Ben Kwa, 2015-03-24 20:16:32]

Patchset #2 (id:20001) has been deleted

[Ben Kwa, 2015-03-24 20:17:19]

https://codereview.chromium.org/1035483004/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/common/js/metrics.js (right):

https://codereview.chromium.org/1035483004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/common/js/metrics.js:57: metrics.analytics_ =
analytics.getService('Files app');
On 2015/03/24 20:07:58, Steve McKay wrote:
> I'd rather know if this condition is ever happening. Let's make this version
> '0.0'.

Done.

[Steve McKay, 2015-03-24 22:38:17]

The CQ bit was checked by smckay@chromium.org

[Steve McKay, 2015-03-24 22:38:18]

The patchset sent to the CQ was uploaded after l-g-t-m from smckay@chromium.org
Link to the patchset: https://codereview.chromium.org/1035483004/#ps40001
(title: "Provide a known default version string.")

[commit-bot: I haz the power, 2015-03-24 22:38:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035483004/40001

[Ben Kwa, 2015-03-24 23:00:24]

Tomasz, mind just hitting the 'LG and CQ' button if this looks good to you?
Thanks!

[commit-bot: I haz the power, 2015-03-24 23:52:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-24 23:52:18]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mtomasz, 2015-03-25 00:46:16]

lgtm with one optional comment, which can be (optionally) done in a separate CL.

https://codereview.chromium.org/1035483004/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/common/js/metrics.js (right):

https://codereview.chromium.org/1035483004/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/metrics.js:55: metrics.analytics_ =
analytics.getService('Files app', chromeVersion[1]);
optional: This holds milestone only. Shall we keep the entire version string, so
we eg. can see that errors happen since some specific dev/canary release?

[mtomasz, 2015-03-25 00:46:19]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2015-03-25 00:47:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035483004/40001

[commit-bot: I haz the power, 2015-03-25 00:54:29]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-03-25 00:55:29]

Patchset 2 (id:??) landed as
https://crrev.com/7d90893641c3024633c1274dd7a1d83af46482fc
Cr-Commit-Position: refs/heads/master@{#322106}