Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Unified Diff: Source/core/paint/DeprecatedPaintLayerPainter.cpp

Issue 1035463002: [S.P.] Use LayoutObject references instead of pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/paint/SVGClipPainter.h » ('j') | Source/core/paint/SVGClipPainter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/DeprecatedPaintLayerPainter.cpp
diff --git a/Source/core/paint/DeprecatedPaintLayerPainter.cpp b/Source/core/paint/DeprecatedPaintLayerPainter.cpp
index fa141d8c62c7b95f59eaf7a9c891a4e55b629d4e..6662d9b7e272b34513e928c559ea803d1e50099c 100644
--- a/Source/core/paint/DeprecatedPaintLayerPainter.cpp
+++ b/Source/core/paint/DeprecatedPaintLayerPainter.cpp
@@ -142,7 +142,8 @@ public:
}
m_resourceClipper = toLayoutSVGResourceClipper(toLayoutSVGResourceContainer(element->layoutObject()));
- if (!SVGClipPainter(*m_resourceClipper).applyClippingToContext(renderLayer.layoutObject(), rootRelativeBounds,
+ ASSERT(renderLayer.layoutObject());
fs 2015/03/24 14:15:31 This has already been dereferenced above, so this
Erik Dahlström (inactive) 2015/03/24 16:26:00 Done.
+ if (!SVGClipPainter(*m_resourceClipper).applyClippingToContext(*renderLayer.layoutObject(), rootRelativeBounds,
paintingInfo.paintDirtyRect, context, m_clipperState)) {
// No need to post-apply the clipper if this failed.
m_resourceClipper = 0;
@@ -153,8 +154,10 @@ public:
~ClipPathHelper()
{
- if (m_resourceClipper)
- SVGClipPainter(*m_resourceClipper).postApplyStatefulResource(m_renderLayer.layoutObject(), m_context, m_clipperState);
+ if (m_resourceClipper) {
+ ASSERT(m_renderLayer.layoutObject());
fs 2015/03/24 14:15:31 As above.
Erik Dahlström (inactive) 2015/03/24 16:26:00 Done.
+ SVGClipPainter(*m_resourceClipper).postApplyStatefulResource(*m_renderLayer.layoutObject(), m_context, m_clipperState);
+ }
}
private:
LayoutSVGResourceClipper* m_resourceClipper;
« no previous file with comments | « no previous file | Source/core/paint/SVGClipPainter.h » ('j') | Source/core/paint/SVGClipPainter.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698