Move gles2 extensions out of dev.

Move gles2 extensions out of dev.
BUG=none
TEST=simple usage test in nacl
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135735

[jbauman, 2012-05-04 21:25:23]

lgtm

[commit-bot: I haz the power, 2012-05-04 21:28:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nfullagar@google.com/10354004/15006

[commit-bot: I haz the power, 2012-05-04 21:28:17]

Presubmit check for 10354004-15006 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ppapi/native_client/src/shared/ppapi_proxy/plugin_opengles.cc, line 866, 104
chars \
  ppapi/native_client/src/shared/ppapi_proxy/plugin_opengles.cc, line 874, 104
chars \
  ppapi/native_client/src/shared/ppapi_proxy/plugin_opengles.cc, line 880, 118
chars \
  ppapi/native_client/src/shared/ppapi_proxy/plugin_opengles.cc, line 886, 116
chars \
  ppapi/native_client/src/shared/ppapi_proxy/plugin_opengles.cc, line 892, 102
chars

Missing PPAPI IDL for DEV, required before moving to stable:

***************
  ppapi/c/dev/ppb_opengles2ext_dev.h
***************

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ppapi/proxy
    webkit/plugins/ppapi
    ppapi

Missing PPAPI IDL for stable interface:

***************
  ppapi/c/ppb_opengles2.h
***************

Presubmit checks took 7.9s to calculate.

[dmichael (off chromium), 2012-05-05 00:31:29]

lgtm

[viettrungluu, 2012-05-07 20:47:46]

http://codereview.chromium.org/10354004/diff/17009/ppapi/c/dev/ppb_opengles2e...
File ppapi/c/dev/ppb_opengles2ext_dev.h (right):

http://codereview.chromium.org/10354004/diff/17009/ppapi/c/dev/ppb_opengles2e...
ppapi/c/dev/ppb_opengles2ext_dev.h:15: 
Why exactly is this file being kept around?

http://codereview.chromium.org/10354004/diff/17009/ppapi/lib/gl/gles2/gl2ext_...
File ppapi/lib/gl/gles2/gl2ext_ppapi.c (right):

http://codereview.chromium.org/10354004/diff/17009/ppapi/lib/gl/gles2/gl2ext_...
ppapi/lib/gl/gles2/gl2ext_ppapi.c:69: g_gles2_chromium_map_sub_interface =
Flapper doesn't use |glGetChromiumMapSubInterfacePPAPI()| (or any of other
formerly-Dev ones) AFAIK, but it's unfortunate that we'll have fallback if
someone gets the interface themselves but not if they use the
glGet...InterfacePPAPI() functions.

http://codereview.chromium.org/10354004/diff/17009/ppapi/proxy/interface_list.cc
File ppapi/proxy/interface_list.cc (right):

http://codereview.chromium.org/10354004/diff/17009/ppapi/proxy/interface_list...
ppapi/proxy/interface_list.cc:206:
AddPPB("PPB_OpenGLES2ChromiumMapSub(Dev);1.0", API_ID_NONE,
I'd prefer that the name be kept around in a header file (under ppapi/c), as
long as we keep on having to support it.

(Otherwise, I'll have to hardcode elsewhere, and won't notice when support for
it is pulled. Note that Flapper needs to keep on checking for the Dev interface
until the non-Dev one hits Stable.)

[nfullagar, 2012-05-07 21:13:57]

#define added for depericated dev interface.  PTAL, thx!

http://codereview.chromium.org/10354004/diff/17009/ppapi/c/dev/ppb_opengles2e...
File ppapi/c/dev/ppb_opengles2ext_dev.h (right):

http://codereview.chromium.org/10354004/diff/17009/ppapi/c/dev/ppb_opengles2e...
ppapi/c/dev/ppb_opengles2ext_dev.h:15: 
On 2012/05/07 20:47:46, viettrungluu wrote:
> Why exactly is this file being kept around?
It's autogenerated from gpu/command_buffer/build_gles2_cmd_buffer.py.  More
OpenGL extensions might come in, and this is where they start life as a dev
interface.  It's empty now, but if we remove it, we'll have to keep changing the
build files.

http://codereview.chromium.org/10354004/diff/17009/ppapi/lib/gl/gles2/gl2ext_...
File ppapi/lib/gl/gles2/gl2ext_ppapi.c (right):

http://codereview.chromium.org/10354004/diff/17009/ppapi/lib/gl/gles2/gl2ext_...
ppapi/lib/gl/gles2/gl2ext_ppapi.c:69: g_gles2_chromium_map_sub_interface =
On 2012/05/07 20:47:46, viettrungluu wrote:
> Flapper doesn't use |glGetChromiumMapSubInterfacePPAPI()| (or any of other
> formerly-Dev ones) AFAIK, but it's unfortunate that we'll have fallback if
> someone gets the interface themselves but not if they use the
> glGet...InterfacePPAPI() functions.

I'm not sure who this would affect.  NaCl apps can't ship with Dev interfaces. 
Are there other clients besides Flapper & NaCl who use this extension?

http://codereview.chromium.org/10354004/diff/17009/ppapi/proxy/interface_list.cc
File ppapi/proxy/interface_list.cc (right):

http://codereview.chromium.org/10354004/diff/17009/ppapi/proxy/interface_list...
ppapi/proxy/interface_list.cc:206:
AddPPB("PPB_OpenGLES2ChromiumMapSub(Dev);1.0", API_ID_NONE,
On 2012/05/07 20:47:46, viettrungluu wrote:
> I'd prefer that the name be kept around in a header file (under ppapi/c), as
> long as we keep on having to support it.
> 
> (Otherwise, I'll have to hardcode elsewhere, and won't notice when support for
> it is pulled. Note that Flapper needs to keep on checking for the Dev
interface
> until the non-Dev one hits Stable.)
I can put it in ppb_gles_chromium_texture_mapping_dev.h for now.  Not perfect,
but the other gl ext headers are autogenerated.

[viettrungluu, 2012-05-07 21:54:32]

lgtm

[nfullagar, 2012-05-07 23:06:00]

thx,
Committed revision 135735.

[Wez, 2012-05-14 22:33:13]

https://chromiumcodereview.appspot.com/10354004/diff/25008/webkit/plugins/ppa...
File webkit/plugins/ppapi/plugin_module.cc (right):

https://chromiumcodereview.appspot.com/10354004/diff/25008/webkit/plugins/ppa...
webkit/plugins/ppapi/plugin_module.cc:324: if (strcmp(name,
PPB_OPENGLES2_INTERFACE) == 0)
This and the rest of the non-dev PPB_OPENGLES2_<foo> interface cases should use
the versioned macros.