Issue 103533012: Disk Cache: Use the old WorkerPool for Async IO on iOS.

Issue 103533012: Disk Cache: Use the old WorkerPool for Async IO on iOS. (Closed)

Created:
6 years, 11 months ago by rvargas (doing something else)

Modified:
6 years, 11 months ago

Reviewers:
gavinp

CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, andrea, stuartmorgan

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disk Cache: Use the old WorkerPool for Async IO on iOS. This basically reverts r222408 for iOS BUG=330074 TEST=net_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243495

Patch Set 3 : Nits #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -54 lines)			Patch
M	net/disk_cache/backend_impl.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/disk_cache/backend_unittest.cc	View	1	3 chunks	+8 lines, -1 line	0 comments	Download
M	net/disk_cache/file.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
A +	net/disk_cache/file_ios.cc	View	1	6 chunks	+168 lines, -53 lines	0 comments	Download
M	net/disk_cache/file_posix.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/disk_cache/file_win.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
	net/net.gyp	View	1 2	1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

gavinp

LGTM. https://codereview.chromium.org/103533012/diff/70001/net/disk_cache/file_posix.cc File net/disk_cache/file_posix.cc (right): https://codereview.chromium.org/103533012/diff/70001/net/disk_cache/file_posix.cc#newcode172 net/disk_cache/file_posix.cc:172: // Nothing to do here. Drop this comment. ...

6 years, 11 months ago (2014-01-07 15:50:42 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/103533012/180001

6 years, 11 months ago (2014-01-07 19:47:09 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242659

6 years, 11 months ago (2014-01-07 21:58:32 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/103533012/180001

6 years, 11 months ago (2014-01-08 02:25:39 UTC) #5

stuartmorgan

6 years, 11 months ago (2014-01-25 00:04:54 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/103533012/diff/180001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/103533012/diff/180001/net/net.gyp#newcode383
net/net.gyp:383: 'disk_cache/file_ios.cc',
So you're adding file_ios.cc, which has a bunch of duplication from
file_posix.cc, but not doing anything to remove file_posix from the iOS build.
How is this supposed to work? I'm not clear on why this builds in our tree;
huey@ is seeing what seems like perfectly reasonable link errors from duplicate
symbols when building net stand-alone for iOS.

Is there magic here I'm missing that makes this work and that needs to be
replicated in other builds, or are we just lucky (?) somehow that this compiles
for us?

Expand Messages | Collapse Messages