Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 103533008: Mojo: More data pipe implementation. (Closed)

Created:
7 years ago by viettrungluu
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: More data pipe implementation. Implement the dispatcher for the producer side (DataPipeProducerDispatcher); the consumer side will be similar. Implement most of the base class for the connecting part (DataPipe). Subclasses will provide implementations for the various cases (both local, local producer/remote consumer, remote producer/local consumer). The setup is similar to that for MessagePipe, but factored a bit differently since the sides aren't symmetric (hence no gain in factoring out the endpoint code). R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240774

Patch Set 1 #

Total comments: 2

Patch Set 2 : indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+455 lines, -24 lines) Patch
M mojo/mojo.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/system/core.h View 2 chunks +7 lines, -2 lines 0 comments Download
M mojo/public/system/core_private.h View 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/public/system/core_private.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M mojo/system/core_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/system/core_impl.cc View 3 chunks +46 lines, -7 lines 0 comments Download
A mojo/system/data_pipe.h View 1 chunk +100 lines, -0 lines 0 comments Download
A mojo/system/data_pipe.cc View 1 1 chunk +103 lines, -0 lines 0 comments Download
A mojo/system/data_pipe_producer_dispatcher.h View 1 chunk +61 lines, -0 lines 0 comments Download
A mojo/system/data_pipe_producer_dispatcher.cc View 1 chunk +100 lines, -0 lines 0 comments Download
M mojo/system/memory.h View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/system/memory.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M mojo/system/message_pipe.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/system/message_pipe.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/system/message_pipe_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/system/message_pipe_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
This doesn't actually do anything yet, and isn't hooked up. But data_pipe_producer.* are complete, and ...
7 years ago (2013-12-13 22:03:42 UTC) #1
sky
LGTM https://codereview.chromium.org/103533008/diff/1/mojo/system/data_pipe.cc File mojo/system/data_pipe.cc (right): https://codereview.chromium.org/103533008/diff/1/mojo/system/data_pipe.cc#newcode71 mojo/system/data_pipe.cc:71: MojoWaitFlags flags, nit: spacing
7 years ago (2013-12-13 22:16:21 UTC) #2
viettrungluu
Thanks. https://codereview.chromium.org/103533008/diff/1/mojo/system/data_pipe.cc File mojo/system/data_pipe.cc (right): https://codereview.chromium.org/103533008/diff/1/mojo/system/data_pipe.cc#newcode71 mojo/system/data_pipe.cc:71: MojoWaitFlags flags, On 2013/12/13 22:16:21, sky wrote: > ...
7 years ago (2013-12-13 22:22:48 UTC) #3
viettrungluu
7 years ago (2013-12-13 22:23:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r240774 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698