Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 103533003: Add last-push check to automatic push-to-trunk script. (Closed)

Created:
7 years ago by Michael Achenbach
Modified:
7 years ago
Reviewers:
ulan
CC:
v8-dev, Jakob Kummerow
Visibility:
Public.

Description

Add last-push check to automatic push-to-trunk script. Make sure the script is not trying a push-to-trunk twice in a row. This also passes through some command line parameters. TEST=python -m unittest test_scripts.ScriptTest.testCheckLastPushRecently R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18306

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M tools/push-to-trunk/auto_roll.py View 5 chunks +32 lines, -3 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years ago (2013-12-06 10:08:23 UTC) #1
ulan
lgtm
7 years ago (2013-12-11 15:19:36 UTC) #2
Michael Achenbach
7 years ago (2013-12-11 15:27:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18306.

Powered by Google App Engine
This is Rietveld 408576698