Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: chrome/test/chromedriver/test/run_py_tests.py

Issue 1035323003: [chromedriver] Allow the Offline test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/client/chromedriver.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/test/run_py_tests.py
diff --git a/chrome/test/chromedriver/test/run_py_tests.py b/chrome/test/chromedriver/test/run_py_tests.py
index 8ed26515ef01a891eb2e8e8486dd64e3e185ca3c..6a417f337ad9083805827d9b2f0099f2ecd99e7c 100755
--- a/chrome/test/chromedriver/test/run_py_tests.py
+++ b/chrome/test/chromedriver/test/run_py_tests.py
@@ -50,8 +50,6 @@ _NEGATIVE_FILTER = [
# This test is flaky since it uses setTimeout.
# Re-enable once crbug.com/177511 is fixed and we can remove setTimeout.
'ChromeDriverTest.testAlert',
- # Enable per-browser when http://crbug.com/456324 is fixed.
- 'ChromeDriverTest.testEmulateNetworkConditionsOffline',
# This test is too flaky on the bots, but seems to run perfectly fine
# on developer workstations.
'ChromeDriverTest.testEmulateNetworkConditionsNameSpeed',
@@ -882,7 +880,9 @@ class ChromeDriverTest(ChromeDriverBaseTest):
self.assertGreaterEqual(actual_throughput_kbps, throughput_kbps / 1.5)
def testEmulateNetworkConditionsOffline(self):
- self._driver.SetNetworkConditions(5, 2048, 2048, offline=True)
+ # A workaround for crbug.com/177511; when setting offline, the throughputs
+ # must be 0.
+ self._driver.SetNetworkConditions(0, 0, 0, offline=True)
self._driver.Load(self.GetHttpUrlForFile('/chromedriver/page_test.html'))
self.assertIn('is not available', self._driver.GetTitle())
« no previous file with comments | « chrome/test/chromedriver/client/chromedriver.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698