content: Remove non-thread-safe use of WeakPtrs.

content: Remove non-thread-safe use of WeakPtrs.

Instead of avoiding to send IPC from ChildDiscardableSharedMemoryManager
dtor, make sure ThreadSafeSender instance is still valid at the
time dtor is called.

BUG=471246
Committed: https://crrev.com/fc8a910c301cc98f5667dfc353e9ba817a78d378
Cr-Commit-Position: refs/heads/master@{#322665}

[reveman, 2015-03-27 21:08:36]

reveman@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2015-03-27 21:13:01]

https://codereview.chromium.org/1035313002/diff/1/content/child/child_discard...
File content/child/child_discardable_shared_memory_manager.cc (right):

https://codereview.chromium.org/1035313002/diff/1/content/child/child_discard...
content/child/child_discardable_shared_memory_manager.cc:74: void
DeletedDiscardableSharedMemory(
We name functions based on what they do, not when they are called.

For example:
- AllocateLockedDiscardableMemory
- LockSpan
- ReleaseFreeMemory

Name this after what it does.

[reveman, 2015-03-27 21:27:35]

https://codereview.chromium.org/1035313002/diff/1/content/child/child_discard...
File content/child/child_discardable_shared_memory_manager.cc (right):

https://codereview.chromium.org/1035313002/diff/1/content/child/child_discard...
content/child/child_discardable_shared_memory_manager.cc:74: void
DeletedDiscardableSharedMemory(
On 2015/03/27 at 21:13:01, Avi wrote:
> We name functions based on what they do, not when they are called.
> 
> For example:
> - AllocateLockedDiscardableMemory
> - LockSpan
> - ReleaseFreeMemory
> 
> Name this after what it does.

Hm, this is supposed to handle the notification that DiscardableSharedMemory
instance was deleted. The current name matches the IPC and the IPC name matches
a number of similar IPCs. We could call it something like
NotifyHostThatDiscardableSharedMemoryWasDeleted here but I think I prefer to
keep this as it is. I don't feel that strongly about though and will change to
NotifyHost... if you prefer that?

[Avi (use Gerrit), 2015-03-27 21:38:46]

https://codereview.chromium.org/1035313002/diff/1/content/child/child_discard...
File content/child/child_discardable_shared_memory_manager.cc (right):

https://codereview.chromium.org/1035313002/diff/1/content/child/child_discard...
content/child/child_discardable_shared_memory_manager.cc:74: void
DeletedDiscardableSharedMemory(
On 2015/03/27 21:27:34, reveman wrote:
> On 2015/03/27 at 21:13:01, Avi wrote:
> > We name functions based on what they do, not when they are called.
> > 
> > For example:
> > - AllocateLockedDiscardableMemory
> > - LockSpan
> > - ReleaseFreeMemory
> > 
> > Name this after what it does.
> 
> Hm, this is supposed to handle the notification that DiscardableSharedMemory
> instance was deleted. The current name matches the IPC and the IPC name
matches
> a number of similar IPCs. We could call it something like
> NotifyHostThatDiscardableSharedMemoryWasDeleted here but I think I prefer to
> keep this as it is. I don't feel that strongly about though and will change to
> NotifyHost... if you prefer that?

Something like SendMemoryDeletedMessage?. I'm looking for a verb to be the first
word.

[reveman, 2015-03-27 21:53:53]

PTAL

https://codereview.chromium.org/1035313002/diff/1/content/child/child_discard...
File content/child/child_discardable_shared_memory_manager.cc (right):

https://codereview.chromium.org/1035313002/diff/1/content/child/child_discard...
content/child/child_discardable_shared_memory_manager.cc:74: void
DeletedDiscardableSharedMemory(
On 2015/03/27 21:38:46, Avi wrote:
> On 2015/03/27 21:27:34, reveman wrote:
> > On 2015/03/27 at 21:13:01, Avi wrote:
> > > We name functions based on what they do, not when they are called.
> > > 
> > > For example:
> > > - AllocateLockedDiscardableMemory
> > > - LockSpan
> > > - ReleaseFreeMemory
> > > 
> > > Name this after what it does.
> > 
> > Hm, this is supposed to handle the notification that DiscardableSharedMemory
> > instance was deleted. The current name matches the IPC and the IPC name
> matches
> > a number of similar IPCs. We could call it something like
> > NotifyHostThatDiscardableSharedMemoryWasDeleted here but I think I prefer to
> > keep this as it is. I don't feel that strongly about though and will change
to
> > NotifyHost... if you prefer that?
> 
> Something like SendMemoryDeletedMessage?. I'm looking for a verb to be the
first
> word.

SendDeletedDiscardableSharedMemoryMessage where "DeletedDiscardableSharedMemory"
is the name of the IPC message.

[Avi (use Gerrit), 2015-03-27 21:55:03]

lgtm

[reveman, 2015-03-27 21:58:51]

The CQ bit was checked by reveman@chromium.org

[reveman, 2015-03-27 21:58:51]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1035313002/#ps40001
(title: "cl format")

[commit-bot: I haz the power, 2015-03-27 21:59:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035313002/40001

[commit-bot: I haz the power, 2015-03-27 22:50:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-27 22:51:30]

Patchset 3 (id:??) landed as
https://crrev.com/fc8a910c301cc98f5667dfc353e9ba817a78d378
Cr-Commit-Position: refs/heads/master@{#322665}