Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: chrome/browser/extensions/chrome_extension_web_contents_observer.h

Issue 1035263002: Add service registration for Mojo services defined under chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_extension_web_contents_observer.h
diff --git a/chrome/browser/extensions/chrome_extension_web_contents_observer.h b/chrome/browser/extensions/chrome_extension_web_contents_observer.h
index e50119984f276013694c2a0775832242b3d10d18..3a98075240bdf8f36fbdde890be8d6841c711e14 100644
--- a/chrome/browser/extensions/chrome_extension_web_contents_observer.h
+++ b/chrome/browser/extensions/chrome_extension_web_contents_observer.h
@@ -34,6 +34,8 @@ class ChromeExtensionWebContentsObserver
void RenderViewCreated(content::RenderViewHost* render_view_host) override;
bool OnMessageReceived(const IPC::Message& message,
content::RenderFrameHost* render_frame_host) override;
+ void RegisterMojoServices(content::RenderFrameHost* render_frame_host,
mark a. foltz 2015/03/27 20:24:11 Usually observers don't expose methods to callers
Kevin M 2015/03/27 22:42:37 Moved this out of the WebContentsObserver override
Sam McNally 2015/03/31 23:38:51 This might be better off as a method in Extensions
Kevin M 2015/04/01 23:23:50 Done, thanks for the suggestion.
+ const Extension* extension) override;
// Adds a message to the extensions ErrorConsole.
void OnDetailedConsoleMessageAdded(const base::string16& message,

Powered by Google App Engine
This is Rietveld 408576698