Add IDN decoding test for SafeBrowsingBlockingPage

Add IDN decoding test for SafeBrowsingBlockingPage

This uses the SecurityInterstitialIDNTest class to implement a test that
Safe Browsing blocking pages decode IDN correctly.

BUG=470406
Committed: https://crrev.com/ac201157369195adc785270b14504f7f3f87bf26
Cr-Commit-Position: refs/heads/master@{#322682}

[estark, 2015-03-27 15:43:33]

estark@chromium.org changed reviewers:
+ meacer@chromium.org

[estark, 2015-03-27 15:43:34]

Mustafa, could you please take a look? This is a follow-up to 1000333003... I
don't know why I convinced myself that it would be so hard; much easier than
expected!

[meacer, 2015-03-27 19:27:58]

I too was convinced it would be hard! LGTM, but you'll also need an OWNERS
reviewer.

https://codereview.chromium.org/1035143002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (right):

https://codereview.chromium.org/1035143002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc:797: class
SafeBrowsingBlockingPageIDNTest : public SecurityInterstitialIDNTest {
nit: Might want to add a comment about what we are testing here.

[estark, 2015-03-27 20:31:39]

Thanks Mustafa.

mattm@, could you please take a look? (This is a follow-up to
https://codereview.chromium.org/1000333003/ if you want more context.) Thanks!

https://codereview.chromium.org/1035143002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (right):

https://codereview.chromium.org/1035143002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc:797: class
SafeBrowsingBlockingPageIDNTest : public SecurityInterstitialIDNTest {
On 2015/03/27 19:27:58, Mustafa Emre Acer wrote:
> nit: Might want to add a comment about what we are testing here.

Done.

[estark, 2015-03-27 20:32:09]

estark@chromium.org changed reviewers:
+ mattm@chromium.org

[estark, 2015-03-27 20:32:10]

(oops, actually adding mattm@ this time)

mattm@, could you please take a look? (This is a follow-up to
https://codereview.chromium.org/1000333003/ if you want more context.) Thanks!

[mattm, 2015-03-27 22:47:26]

https://codereview.chromium.org/1035143002/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (right):

https://codereview.chromium.org/1035143002/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc:818: //
constructor, unlike the real thing.
Does that matter for this test? woudn't
SafeBrowsingBlockingPage::CreateBlockingPage work?

[estark, 2015-03-27 22:51:49]

https://codereview.chromium.org/1035143002/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (right):

https://codereview.chromium.org/1035143002/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc:818: //
constructor, unlike the real thing.
On 2015/03/27 22:47:25, mattm wrote:
> Does that matter for this test? woudn't
> SafeBrowsingBlockingPage::CreateBlockingPage work?

Done.

[mattm, 2015-03-27 22:55:49]

https://codereview.chromium.org/1035143002/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (right):

https://codereview.chromium.org/1035143002/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc:811:
resource.threat_type = SB_THREAT_TYPE_URL_MALWARE;
Probably should make this a parameterized test like
SafeBrowsingBlockingPageBrowserTest.

https://codereview.chromium.org/1035143002/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc:829:
SB_THREAT_TYPE_URL_UNWANTED));
Move the new test so it's not between the SafeBrowsingBlockingPageBrowserTest
and its INSTANTIATE_TEST_CASE_P.

[estark, 2015-03-27 23:10:40]

https://codereview.chromium.org/1035143002/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (right):

https://codereview.chromium.org/1035143002/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc:811:
resource.threat_type = SB_THREAT_TYPE_URL_MALWARE;
On 2015/03/27 22:55:49, mattm wrote:
> Probably should make this a parameterized test like
> SafeBrowsingBlockingPageBrowserTest.

Done.

https://codereview.chromium.org/1035143002/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc:829:
SB_THREAT_TYPE_URL_UNWANTED));
On 2015/03/27 22:55:49, mattm wrote:
> Move the new test so it's not between the SafeBrowsingBlockingPageBrowserTest
> and its INSTANTIATE_TEST_CASE_P.

Done.

[mattm, 2015-03-27 23:25:31]

lgtm

[estark, 2015-03-27 23:26:23]

The CQ bit was checked by estark@chromium.org

[estark, 2015-03-27 23:26:23]

The patchset sent to the CQ was uploaded after l-g-t-m from meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/1035143002/#ps60001
(title: "make IDN test parameterized")

[commit-bot: I haz the power, 2015-03-27 23:26:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035143002/60001

[commit-bot: I haz the power, 2015-03-28 00:07:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-28 00:08:11]

Patchset 4 (id:??) landed as
https://crrev.com/ac201157369195adc785270b14504f7f3f87bf26
Cr-Commit-Position: refs/heads/master@{#322682}