Add ReverseIter to GrTRecorder

Add ReverseIter to GrTRecorder

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/72badbd99e2321bfbcb22f78218bbafa71af4698

[Mark Kilgard, 2015-04-02 22:48:15]

markkilgard@gmail.com changed reviewers:
+ markkilgard@gmail.com

[Mark Kilgard, 2015-04-02 22:48:15]

lgtm

[bsalomon, 2015-04-16 14:36:09]

bsalomon@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2015-04-16 14:36:10]

lgtm

[Chris Dalton, 2015-04-16 15:03:56]

The CQ bit was checked by cdalton@nvidia.com

[commit-bot: I haz the power, 2015-04-16 15:04:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035083004/20001

[commit-bot: I haz the power, 2015-04-16 15:16:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 15:16:04]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[Chris Dalton, 2015-04-16 17:18:50]

The CQ bit was checked by cdalton@nvidia.com

[Chris Dalton, 2015-04-16 17:18:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
markkilgard@gmail.com, bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1035083004/#ps40001
(title: "Overriding hooks to put the SK_SUPPORT_GPU check back where it was")

[commit-bot: I haz the power, 2015-04-16 17:19:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035083004/40001

[commit-bot: I haz the power, 2015-04-16 17:19:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 17:19:11]

Presubmit check for 1035083004-40001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
The following files have #if or #ifdef before includes:
tests/GrTRecorderTest.cpp

See skbug.com/3362 for why this should be fixed.

[Chris Dalton, 2015-04-16 17:21:35]

On 2015/04/16 17:19:11, I haz the power (commit-bot) wrote:
> Presubmit check for 1035083004-40001 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit ERRORS **
> The following files have #if or #ifdef before includes:
> tests/GrTRecorderTest.cpp
> 
> See skbug.com/3362 for why this should be fixed.

The build seems to fail if we have GPU includes outside an "#if SK_SUPPORT_GPU"
block, but the presubmit checks fail if an include is inside that block. Is
there a way I can work around this?

[bsalomon, 2015-04-16 17:27:49]

On 2015/04/16 17:21:35, Chris Dalton wrote:
> On 2015/04/16 17:19:11, I haz the power (commit-bot) wrote:
> > Presubmit check for 1035083004-40001 failed and returned exit status 1.
> > 
> > Running presubmit commit checks ...
> > 
> > ** Presubmit ERRORS **
> > The following files have #if or #ifdef before includes:
> > tests/GrTRecorderTest.cpp
> > 
> > See skbug.com/3362 for why this should be fixed.
> 
> The build seems to fail if we have GPU includes outside an "#if
SK_SUPPORT_GPU"
> block, but the presubmit checks fail if an include is inside that block. Is
> there a way I can work around this?

Include SkTypes.h before the #if SK_SUPPORT_GPU. It will ensure that the
SK_SUPPORT_GPU macro is defined before it is used.

[Chris Dalton, 2015-04-16 17:35:25]

The CQ bit was checked by cdalton@nvidia.com

[Chris Dalton, 2015-04-16 17:35:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
markkilgard@gmail.com, bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1035083004/#ps60001
(title: "Rearrange headers")

[commit-bot: I haz the power, 2015-04-16 17:35:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035083004/60001

[Chris Dalton, 2015-04-16 17:37:27]

On 2015/04/16 17:27:49, bsalomon wrote:
> On 2015/04/16 17:21:35, Chris Dalton wrote:
> > On 2015/04/16 17:19:11, I haz the power (commit-bot) wrote:
> > > Presubmit check for 1035083004-40001 failed and returned exit status 1.
> > > 
> > > Running presubmit commit checks ...
> > > 
> > > ** Presubmit ERRORS **
> > > The following files have #if or #ifdef before includes:
> > > tests/GrTRecorderTest.cpp
> > > 
> > > See skbug.com/3362 for why this should be fixed.
> > 
> > The build seems to fail if we have GPU includes outside an "#if
> SK_SUPPORT_GPU"
> > block, but the presubmit checks fail if an include is inside that block. Is
> > there a way I can work around this?
> 
> Include SkTypes.h before the #if SK_SUPPORT_GPU. It will ensure that the
> SK_SUPPORT_GPU macro is defined before it is used.

Ok got it, thanks. I was understanding that message to mean "There is an
#include inside an #if", not "There is an #if before any #include"

[commit-bot: I haz the power, 2015-04-16 17:42:52]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/72badbd99e2321bfbcb22f78218bbafa71af4698