Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: cc/resources/tile_manager_unittest.cc

Issue 1035043002: cc: Fix memory limit edge cases for SetIsLikelyToRequireADraw. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/resources/tile_manager.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/eviction_tile_priority_queue.h" 5 #include "cc/resources/eviction_tile_priority_queue.h"
6 #include "cc/resources/raster_tile_priority_queue.h" 6 #include "cc/resources/raster_tile_priority_queue.h"
7 #include "cc/resources/resource_pool.h"
7 #include "cc/resources/tile.h" 8 #include "cc/resources/tile.h"
8 #include "cc/resources/tile_priority.h" 9 #include "cc/resources/tile_priority.h"
9 #include "cc/resources/tiling_set_raster_queue_all.h" 10 #include "cc/resources/tiling_set_raster_queue_all.h"
10 #include "cc/test/begin_frame_args_test.h" 11 #include "cc/test/begin_frame_args_test.h"
11 #include "cc/test/fake_impl_proxy.h" 12 #include "cc/test/fake_impl_proxy.h"
12 #include "cc/test/fake_layer_tree_host_impl.h" 13 #include "cc/test/fake_layer_tree_host_impl.h"
13 #include "cc/test/fake_output_surface.h" 14 #include "cc/test/fake_output_surface.h"
14 #include "cc/test/fake_output_surface_client.h" 15 #include "cc/test/fake_output_surface_client.h"
15 #include "cc/test/fake_picture_layer_impl.h" 16 #include "cc/test/fake_picture_layer_impl.h"
16 #include "cc/test/fake_picture_layer_tiling_client.h" 17 #include "cc/test/fake_picture_layer_tiling_client.h"
(...skipping 1275 matching lines...) Expand 10 before | Expand all | Expand 10 after
1292 SAME_PRIORITY_FOR_BOTH_TREES, RasterTilePriorityQueue::Type::ALL)); 1293 SAME_PRIORITY_FOR_BOTH_TREES, RasterTilePriorityQueue::Type::ALL));
1293 EXPECT_FALSE(queue->IsEmpty()); 1294 EXPECT_FALSE(queue->IsEmpty());
1294 EXPECT_TRUE(queue->Top()->required_for_draw()); 1295 EXPECT_TRUE(queue->Top()->required_for_draw());
1295 1296
1296 EXPECT_FALSE(host_impl_.is_likely_to_require_a_draw()); 1297 EXPECT_FALSE(host_impl_.is_likely_to_require_a_draw());
1297 host_impl_.tile_manager()->PrepareTiles(host_impl_.global_tile_state()); 1298 host_impl_.tile_manager()->PrepareTiles(host_impl_.global_tile_state());
1298 EXPECT_TRUE(host_impl_.is_likely_to_require_a_draw()); 1299 EXPECT_TRUE(host_impl_.is_likely_to_require_a_draw());
1299 } 1300 }
1300 1301
1301 TEST_F(TileManagerTilePriorityQueueTest, 1302 TEST_F(TileManagerTilePriorityQueueTest,
1302 NoSetIsLikelyToRequireADrawOnZeroMemoryBudget) { 1303 SetIsLikelyToRequireADrawOnZeroMemoryBudget) {
1303 const gfx::Size layer_bounds(1000, 1000); 1304 const gfx::Size layer_bounds(1000, 1000);
1304 host_impl_.SetViewportSize(layer_bounds); 1305 host_impl_.SetViewportSize(layer_bounds);
1305 SetupDefaultTrees(layer_bounds); 1306 SetupDefaultTrees(layer_bounds);
1306 1307
1307 // Verify that the queue has a required for draw tile at Top. 1308 // Verify that the queue has a required for draw tile at Top.
1308 scoped_ptr<RasterTilePriorityQueue> queue(host_impl_.BuildRasterQueue( 1309 scoped_ptr<RasterTilePriorityQueue> queue(host_impl_.BuildRasterQueue(
1309 SAME_PRIORITY_FOR_BOTH_TREES, RasterTilePriorityQueue::Type::ALL)); 1310 SAME_PRIORITY_FOR_BOTH_TREES, RasterTilePriorityQueue::Type::ALL));
1310 EXPECT_FALSE(queue->IsEmpty()); 1311 EXPECT_FALSE(queue->IsEmpty());
1311 EXPECT_TRUE(queue->Top()->required_for_draw()); 1312 EXPECT_TRUE(queue->Top()->required_for_draw());
1312 1313
1313 ManagedMemoryPolicy policy = host_impl_.ActualManagedMemoryPolicy(); 1314 ManagedMemoryPolicy policy = host_impl_.ActualManagedMemoryPolicy();
1314 policy.bytes_limit_when_visible = 0; 1315 policy.bytes_limit_when_visible = 0;
1315 host_impl_.SetMemoryPolicy(policy); 1316 host_impl_.SetMemoryPolicy(policy);
1316 1317
1317 EXPECT_FALSE(host_impl_.is_likely_to_require_a_draw()); 1318 EXPECT_FALSE(host_impl_.is_likely_to_require_a_draw());
1318 host_impl_.tile_manager()->PrepareTiles(host_impl_.global_tile_state()); 1319 host_impl_.tile_manager()->PrepareTiles(host_impl_.global_tile_state());
1319 EXPECT_FALSE(host_impl_.is_likely_to_require_a_draw()); 1320 EXPECT_FALSE(host_impl_.is_likely_to_require_a_draw());
1320 } 1321 }
1321 1322
1323 TEST_F(TileManagerTilePriorityQueueTest,
1324 SetIsLikelyToRequireADrawOnLimitedMemoryBudget) {
1325 const gfx::Size layer_bounds(1000, 1000);
1326 host_impl_.SetViewportSize(layer_bounds);
1327 SetupDefaultTrees(layer_bounds);
1328
1329 // Verify that the queue has a required for draw tile at Top.
1330 scoped_ptr<RasterTilePriorityQueue> queue(host_impl_.BuildRasterQueue(
1331 SAME_PRIORITY_FOR_BOTH_TREES, RasterTilePriorityQueue::Type::ALL));
1332 EXPECT_FALSE(queue->IsEmpty());
1333 EXPECT_TRUE(queue->Top()->required_for_draw());
1334 EXPECT_EQ(gfx::Size(256, 256), queue->Top()->desired_texture_size());
1335 EXPECT_EQ(RGBA_8888, host_impl_.resource_provider()->best_texture_format());
1336
1337 ManagedMemoryPolicy policy = host_impl_.ActualManagedMemoryPolicy();
1338 policy.bytes_limit_when_visible =
1339 Resource::MemorySizeBytes(gfx::Size(256, 256), RGBA_8888);
1340 host_impl_.SetMemoryPolicy(policy);
1341
1342 EXPECT_FALSE(host_impl_.is_likely_to_require_a_draw());
1343 host_impl_.tile_manager()->PrepareTiles(host_impl_.global_tile_state());
1344 EXPECT_TRUE(host_impl_.is_likely_to_require_a_draw());
1345
1346 scoped_ptr<ScopedResource> resource =
1347 host_impl_.resource_pool()->AcquireResource(gfx::Size(256, 256),
1348 RGBA_8888);
1349
1350 host_impl_.tile_manager()->CheckIfMoreTilesNeedToBePreparedForTesting();
1351 EXPECT_FALSE(host_impl_.is_likely_to_require_a_draw());
1352
1353 host_impl_.resource_pool()->ReleaseResource(resource.Pass());
1354 }
1355
1356 TEST_F(TileManagerTilePriorityQueueTest,
1357 SetIsLikelyToRequireADrawOnSynchronousRaster) {
1358 const gfx::Size layer_bounds(1000, 1000);
1359 host_impl_.SetViewportSize(layer_bounds);
1360 host_impl_.SetUseGpuRasterization(true);
1361 EXPECT_EQ(host_impl_.rasterizer()->GetPrepareTilesMode(),
1362 PrepareTilesMode::PREPARE_NONE);
1363 SetupDefaultTrees(layer_bounds);
1364
1365 // Verify that the queue has a required for draw tile at Top.
1366 scoped_ptr<RasterTilePriorityQueue> queue(host_impl_.BuildRasterQueue(
1367 SAME_PRIORITY_FOR_BOTH_TREES, RasterTilePriorityQueue::Type::ALL));
1368 EXPECT_FALSE(queue->IsEmpty());
1369 EXPECT_TRUE(queue->Top()->required_for_draw());
1370
1371 host_impl_.SetIsLikelyToRequireADraw(true);
1372
1373 EXPECT_TRUE(host_impl_.is_likely_to_require_a_draw());
1374 host_impl_.tile_manager()->UpdateVisibleTiles(host_impl_.global_tile_state());
1375 EXPECT_FALSE(host_impl_.is_likely_to_require_a_draw());
1376 }
1377
1322 } // namespace 1378 } // namespace
1323 } // namespace cc 1379 } // namespace cc
OLDNEW
« no previous file with comments | « cc/resources/tile_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698