Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: components/autofill/content/renderer/password_form_conversion_utils.cc

Issue 103503002: Ignore autocomplete='off' for usernames and passwords. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase on ToT Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/content/renderer/password_form_conversion_utils.h" 5 #include "components/autofill/content/renderer/password_form_conversion_utils.h"
6 6
7 #include "components/autofill/content/renderer/form_autofill_util.h" 7 #include "components/autofill/content/renderer/form_autofill_util.h"
8 #include "components/autofill/core/common/password_form.h" 8 #include "components/autofill/core/common/password_form.h"
9 #include "third_party/WebKit/public/web/WebFormControlElement.h" 9 #include "third_party/WebKit/public/web/WebFormControlElement.h"
10 #include "third_party/WebKit/public/web/WebPasswordFormData.h" 10 #include "third_party/WebKit/public/web/WebPasswordFormData.h"
(...skipping 14 matching lines...) Expand all
25 password_form->submit_element = web_password_form.submitElement; 25 password_form->submit_element = web_password_form.submitElement;
26 password_form->username_element = web_password_form.userNameElement; 26 password_form->username_element = web_password_form.userNameElement;
27 password_form->username_value = web_password_form.userNameValue; 27 password_form->username_value = web_password_form.userNameValue;
28 password_form->other_possible_usernames.insert( 28 password_form->other_possible_usernames.insert(
29 password_form->other_possible_usernames.begin(), 29 password_form->other_possible_usernames.begin(),
30 web_password_form.possibleUserNames.data(), 30 web_password_form.possibleUserNames.data(),
31 web_password_form.possibleUserNames.data() + 31 web_password_form.possibleUserNames.data() +
32 web_password_form.possibleUserNames.size()); 32 web_password_form.possibleUserNames.size());
33 password_form->password_element = web_password_form.passwordElement; 33 password_form->password_element = web_password_form.passwordElement;
34 password_form->password_value = web_password_form.passwordValue; 34 password_form->password_value = web_password_form.passwordValue;
35 password_form->password_autocomplete_set =
36 web_password_form.passwordShouldAutocomplete;
37 password_form->old_password_element = web_password_form.oldPasswordElement; 35 password_form->old_password_element = web_password_form.oldPasswordElement;
38 password_form->old_password_value = web_password_form.oldPasswordValue; 36 password_form->old_password_value = web_password_form.oldPasswordValue;
39 password_form->scheme = PasswordForm::SCHEME_HTML; 37 password_form->scheme = PasswordForm::SCHEME_HTML;
40 password_form->ssl_valid = false; 38 password_form->ssl_valid = false;
41 password_form->preferred = false; 39 password_form->preferred = false;
42 password_form->blacklisted_by_user = false; 40 password_form->blacklisted_by_user = false;
43 password_form->type = PasswordForm::TYPE_MANUAL; 41 password_form->type = PasswordForm::TYPE_MANUAL;
44 WebFormElementToFormData(web_form, 42 WebFormElementToFormData(web_form,
45 blink::WebFormControlElement(), 43 blink::WebFormControlElement(),
46 REQUIRE_NONE, 44 REQUIRE_NONE,
47 EXTRACT_NONE, 45 EXTRACT_NONE,
48 &password_form->form_data, 46 &password_form->form_data,
49 NULL /* FormFieldData */); 47 NULL /* FormFieldData */);
50 return scoped_ptr<PasswordForm>(password_form); 48 return scoped_ptr<PasswordForm>(password_form);
51 } 49 }
52 50
53 } // namespace 51 } // namespace
54 52
55 scoped_ptr<PasswordForm> CreatePasswordForm(const WebFormElement& webform) { 53 scoped_ptr<PasswordForm> CreatePasswordForm(const WebFormElement& webform) {
56 WebPasswordFormData web_password_form(webform); 54 WebPasswordFormData web_password_form(webform);
57 if (web_password_form.isValid()) 55 if (web_password_form.isValid())
58 return InitPasswordFormFromWebPasswordForm(webform, web_password_form); 56 return InitPasswordFormFromWebPasswordForm(webform, web_password_form);
59 return scoped_ptr<PasswordForm>(); 57 return scoped_ptr<PasswordForm>();
60 } 58 }
61 59
62 } // namespace autofill 60 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698